DerDu/SPHERE-Framework

View on GitHub

Showing 5,014 of 7,620 total issues

Method insertStudentIntegration has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

        TblPerson $IntegrationPerson = null,
        TblCompany $IntegrationCompany = null,
        $CoachingRequestDate,
        $CoachingCounselDate,
        $CoachingDecisionDate,
Severity: Major
Found in Application/People/Meta/Student/Service.php - About 1 hr to fix

    Method updateSupport has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function updateSupport(TblSupport $tblSupport,
            TblSupportType $tblSupportType,
            $Date,
            $PersonEditor = '',
            $Company = '',
    Severity: Major
    Found in Application/People/Meta/Student/Service/Data/Support.php - About 1 hr to fix

      Method updateHandyCap has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function updateHandyCap(TblHandyCap $tblHandyCap,
              $Date,
              $PersonEditor = '',
              $LegalBasis = '',
              $LearnTarget = '',
      Severity: Major
      Found in Application/People/Meta/Student/Service/Data/Support.php - About 1 hr to fix

        Method updatePerson has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                TblPerson $tblPerson,
                $Salutation,
                $Title,
                $FirstName,
                $SecondName,
        Severity: Major
        Found in Application/People/Person/Service/Data.php - About 1 hr to fix

          Method createHandyCap has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function createHandyCap(TblPerson $serviceTblPerson,
                  $Date,
                  $PersonEditor = '',
                  $LegalBasis = '',
                  $LearnTarget = '',
          Severity: Major
          Found in Application/People/Meta/Student/Service/Data/Support.php - About 1 hr to fix

            Method createPerson has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function createPerson($Salutation, $Title, $FirstName, $SecondName, $CallName, $LastName, $BirthName = '', $ImportId = '')
            Severity: Major
            Found in Application/People/Person/Service/Data.php - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                              if (($tblTask = $tblTest->getTblTask())
                                  && $tblTask->getFromDate()
                                  && $tblTask->getToDate()
                                  && ($fromDate = new \DateTime($tblTask->getFromDate()))
                                  && ($toDate = new \DateTime($tblTask->getToDate()))
              Severity: Major
              Found in Application/Education/Graduation/Evaluation/Service.php - About 1 hr to fix

                Method createTask has 8 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        TblTestType $tblTestType,
                        $Name,
                        $Date = null,
                        $FromDate = null,
                        $ToDate = null,
                Severity: Major
                Found in Application/Education/Graduation/Evaluation/Service/Data.php - About 1 hr to fix

                  Method createProposalBehaviorGrade has 8 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          TblDivision $tblDivision,
                          TblTask $tblTask,
                          TblGradeType $tblGradeType,
                          TblPerson $tblPerson,
                          TblPerson $tblPersonTeacher,
                  Severity: Major
                  Found in Application/Education/Graduation/Gradebook/Service/Data.php - About 1 hr to fix

                    Method updateGrade has 8 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            TblGrade $tblGrade,
                            $Grade,
                            $Comment = '',
                            $PublicComment = '',
                            $Trend = 0,
                    Severity: Major
                    Found in Application/Education/Graduation/Gradebook/Service/Data.php - About 1 hr to fix

                      Consider simplifying this complex logical expression.
                      Open

                                      if ($tblDivisionStudentItem->getLeaveDateTime() !== null
                                          && $tblDivisionStudentItem->getUseGradesInNewDivision()
                                          && ($tblDivisionItem = $tblDivisionStudentItem->getTblDivision())
                                          && $tblDivision->getId() != $tblDivisionItem->getId()
                                          && ($tblYearItem = $tblDivisionItem->getServiceTblYear())
                      Severity: Major
                      Found in Application/Education/Graduation/Gradebook/Service.php - About 1 hr to fix

                        Method updateGradeType has 8 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                TblGradeType $tblGradeType,
                                $Name,
                                $Code,
                                $Description,
                                $IsHighlighted,
                        Severity: Major
                        Found in Application/Education/Graduation/Gradebook/Service/Data.php - About 1 hr to fix

                          Consider simplifying this complex logical expression.
                          Open

                                                  if (($tblConsumer = Consumer::useService()->getConsumerBySession())
                                                      && $tblConsumer->getAcronym() == 'EVSR'
                                                      && $tblGenerateCertificate
                                                      && ($tblCertificateType = $tblGenerateCertificate->getServiceTblCertificateType())
                                                      && $tblCertificateType->getIdentifier() != 'RECOMMENDATION'
                          Severity: Major
                          Found in Application/Education/Certificate/Prepare/Service.php - About 1 hr to fix

                            Method updatePrepareExamGrades has 8 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    IFormInterface $form,
                                    TblPrepareCertificate $tblPrepare,
                                    TblSubject $tblCurrentSubject,
                                    TblSubject $tblNextSubject = null,
                                    $IsFinalGrade = null,
                            Severity: Major
                            Found in Application/Education/Certificate/Prepare/Service.php - About 1 hr to fix

                              Method createPrepareAdditionalGrade has 8 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      TblPrepareCertificate $tblPrepareCertificate,
                                      TblPerson $tblPerson,
                                      TblSubject $tblSubject,
                                      TblPrepareAdditionalGradeType $tblPrepareAdditionalGradeType,
                                      $ranking,
                              Severity: Major
                              Found in Application/Education/Certificate/Prepare/Service.php - About 1 hr to fix

                                Method createPrepareAdditionalGrade has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        TblPrepareCertificate $tblPrepareCertificate,
                                        TblPerson $tblPerson,
                                        TblSubject $tblSubject,
                                        TblPrepareAdditionalGradeType $tblPrepareAdditionalGradeType,
                                        $ranking,
                                Severity: Major
                                Found in Application/Education/Certificate/Prepare/Service/Data.php - About 1 hr to fix

                                  Method frontendPrepareDiplomaSetting has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                          $PrepareId = null,
                                          $GroupId = null,
                                          $SubjectId = null,
                                          $Route = null,
                                          $IsNotSubject = null,
                                  Severity: Major
                                  Found in Application/Education/Certificate/Prepare/Frontend.php - About 1 hr to fix

                                    Consider simplifying this complex logical expression.
                                    Open

                                                                        if (($tblPerson = $tblPrepareStudent->getServiceTblPerson())
                                                                            && ($tblPrepare = $tblPrepareStudent->getTblPrepareCertificate())
                                                                            && $tblPrepareStudent->getServiceTblCertificate()
                                                                            && !$tblPrepareStudent->isPrinted()
                                                                            && ($tblDivisionItem = $tblPrepare->getServiceTblDivision())
                                    Severity: Major
                                    Found in Application/Education/Certificate/PrintCertificate/Frontend.php - About 1 hr to fix

                                      Method updateGenerateCertificate has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                              TblGenerateCertificate $tblGenerateCertificate,
                                              $Date,
                                              $IsDivisionTeacherAvailable,
                                              $HeadmasterName,
                                              TblCommonGender $tblCommonGender = null,
                                      Severity: Major
                                      Found in Application/Education/Certificate/Generate/Service/Data.php - About 1 hr to fix

                                        Consider simplifying this complex logical expression.
                                        Open

                                                if ($SubjectAcronym == 'DE' || $SubjectAcronym == 'D') {
                                                    $tblSubject = Subject::useService()->getSubjectByAcronym('DE');
                                                    if (!$tblSubject) {
                                                        $tblSubject = Subject::useService()->getSubjectByAcronym('D');
                                                    }
                                        Severity: Major
                                        Found in Application/Education/Certificate/Generator/Service/Data.php - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language