DerDu/SPHERE-Framework

View on GitHub

Showing 5,014 of 7,620 total issues

Avoid deeply nested control flow statements.
Open

                                    if (preg_match_all('!\d+!', $Street, $matches)) {
                                        $pos = strpos($Street, $matches[0][0]);
                                        if ($pos !== null) {
                                            $StreetName = trim(substr($Street, 0, $pos));
                                            $StreetNumber = trim(substr($Street, $pos));
Severity: Major
Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                        if ($infoSchool !== '') {
                                            $remarkCommon = 'Name der bisher besuchten Schule: ' . $infoSchool;
                                        }
    Severity: Major
    Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                          if ($pos !== null) {
                                              $StreetName = trim(substr($Street, 0, $pos));
                                              $StreetNumber = trim(substr($Street, $pos));
                                          }
      Severity: Major
      Found in Application/Transfer/Import/Zwickau/Service.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                        if ($tblPerson) {
                                            Relationship::useService()->addCompanyRelationshipToPerson(
                                                $tblCompany,
                                                $tblPerson,
                                                $tblTypeCommon
        Severity: Major
        Found in Application/Transfer/Import/Braeunsdorf/Service.php - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                              if ($pos !== null) {
                                                  $StreetName = trim(substr($Street, 0, $pos));
                                                  $StreetNumber = trim(substr($Street, $pos));
                                              }
          Severity: Major
          Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                                if ($infoSchool !== '') {
                                                    $remarkCommon = 'staatliche GS: ' . $infoSchool;
                                                }
            Severity: Major
            Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                                      if ($pos !== null) {
                                                          $streetName = trim(substr($street, 0, $pos));
                                                          $streetNumber = trim(substr($street, $pos));
                                                      }
              Severity: Major
              Found in Application/Transfer/Import/Zwickau/Service.php - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                                        if ($subjectLanguage !== '') {
                                                            if ($subjectLanguage === 'EN'
                                                                || $subjectLanguage === 'Englisch'
                                                            ) {
                                                                $tblSubject = Subject::useService()->getSubjectByAcronym('EN');
                Severity: Major
                Found in Application/Transfer/Import/Zwickau/Service.php - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                  if (!$tblPerson->fetchMainAddress()) {
                                                      Address::useService()->insertAddressToPerson(
                                                          $tblPerson,
                                                          $streetName,
                                                          $streetNumber,
                  Severity: Major
                  Found in Application/Transfer/Import/Braeunsdorf/Service.php - About 45 mins to fix

                    Method getPriceListByItemAndPerson has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function getPriceListByItemAndPerson(TblItem $tblItem, $Year, $MonthFrom, $MonthTo, TblPerson $tblPerson, $PriceList = array())
                    Severity: Minor
                    Found in Application/Billing/Bookkeeping/Balance/Service.php - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                              if (0 === strpos($phoneNumber, '01')) {
                                                                  $tblType = Phone::useService()->getTypeById(2);
                                                              }
                      Severity: Major
                      Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                                if (0 === strpos($phoneNumber, '01')) {
                                                                    $tblType = Phone::useService()->getTypeById(2);
                                                                }
                        Severity: Major
                        Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                                  switch ($i) {
                                                                      case 3: $tblPhonePerson = $tblPersonMother ? $tblPersonMother : $tblPerson; break;
                                                                      case 4: $tblPhonePerson = $tblPersonFather ? $tblPersonFather : $tblPerson; break;
                                                                      case 1:
                                                                      case 2:
                          Severity: Major
                          Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                                    if (strpos($phone, 'M') !== false) {
                                                                        $remarkPhone = 'Mutter';
                                                                        $phone = trim(str_replace('M', '', $phone));
                                                                    }
                            Severity: Major
                            Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                                      if ($pos !== null) {
                                                                          $streetName = trim(substr($street, 0, $pos));
                                                                          $streetNumber = trim(substr($street, $pos));
                                                                      }
                              Severity: Major
                              Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                                        if ($tblSchoolType) {
                                                                            $tblLevel = Division::useService()->insertLevel($tblSchoolType, $division);
                                                                            if ($tblLevel) {
                                                                                $tblDivision = Division::useService()->insertDivision(
                                                                                    $tblYear,
                                Severity: Major
                                Found in Application/Transfer/Import/Seelitz/Service.php - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                                          if ($arriveSchool) {
                                                                              GroupCompany::useService()->addGroupCompany(
                                                                                  GroupCompany::useService()->getGroupByMetaTable('COMMON'),
                                                                                  $arriveSchool
                                                                              );
                                  Severity: Major
                                  Found in Application/Transfer/Import/Seelitz/Service.php - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                                            if ($pos !== null) {
                                                                                $streetName = trim(substr($street, 0, $pos));
                                                                                $streetNumber = trim(substr($street, $pos));
                                                                            }
                                    Severity: Major
                                    Found in Application/Transfer/Import/Zwickau/Service.php - About 45 mins to fix

                                      Avoid deeply nested control flow statements.
                                      Open

                                                                          if ($pos !== false) {
                                                                              $cityDistrict = trim(substr($cityName, $pos + 4));
                                                                              $cityName = trim(substr($cityName, 0, $pos));
                                                                          }
                                      Severity: Major
                                      Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

                                        Avoid deeply nested control flow statements.
                                        Open

                                                                            if (isset($nameArrayCustody1[1])) {
                                                                                $lastNameCustody1 = $nameArrayCustody1[1];
                                                                            }
                                        Severity: Major
                                        Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language