Sign upLogin

DerDu/SPHERE-Framework

View on GitHub
Star

Showing 5,014 of 7,620 total issues

Avoid deeply nested control flow statements.
Open

                                        if ($subjectLanguage !== '') {
                                            if ($subjectLanguage === 'EN'
                                                || $subjectLanguage === 'Englisch'
                                            ) {
                                                $tblSubject = Subject::useService()->getSubjectByAcronym('EN');
Severity: Major
Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                            if (!$tblPeriodList) {
                                            // firstTerm
                                            $tblPeriod = Term::useService()->insertPeriod(
                                                '1. Halbjahr',
                                                '01.08.20' . $year,
    Severity: Major
    Found in Application/Transfer/Import/Seelitz/Service.php - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                      if (($MailAddress = trim($Document->getValue($Document->getCell($Location['E-Mail Firma'],
                                        $RunY)))) != ''
                                ) {
                                    $tblType = Mail::useService()->getTypeById(2);
                                    Mail::useService()->insertMailToCompany
      Severity: Major
      Found in Application/Transfer/Import/Braeunsdorf/Service.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                            if ($info !== '') {
                                        $remark = 'Geschwister: ' . $info;
                                    }
        Severity: Major
        Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                                  if ($i == 1) {
                                            $tblType = Phone::useService()->getTypeById(5);
                                            if (0 === strpos($phoneNumber, '01')) {
                                                $tblType = Phone::useService()->getTypeById(6);
                                            }
          Severity: Major
          Found in Application/Transfer/Import/Zwickau/Service.php - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                                    if ($tblLevel) {
                                            $tblDivision = Division::useService()->insertDivision(
                                                $tblYear,
                                                $tblLevel,
                                                $division
            Severity: Major
            Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                                      if ($pos !== null) {
                                            $streetName = trim(substr($street, 0, $pos));
                                            $streetNumber = trim(substr($street, $pos));
                                        }
              Severity: Major
              Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                                        if ($tblSubject) {
                                            Student::useService()->addStudentSubject(
                                                $tblStudent,
                                                Student::useService()->getStudentSubjectTypeByIdentifier('RELIGION'),
                                                Student::useService()->getStudentSubjectRankingByIdentifier('1'),
                Severity: Major
                Found in Application/Transfer/Import/Zwickau/Service.php - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                          if ($tblPeriod) {
                                            Term::useService()->insertYearPeriod($tblYear, $tblPeriod);
                                        }
                  Severity: Major
                  Found in Application/Transfer/Import/Coswig/Service.php - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                            if (0 === strpos($phoneNumber, '01')) {
                                            $tblType = Phone::useService()->getTypeById(2);
                                        }
                    Severity: Major
                    Found in Application/Transfer/Import/Seelitz/Service.php - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                              if (0 === strpos($phone, '01')) {
                                            $tblType = Phone::useService()->getTypeById(2);
                                        }
                      Severity: Major
                      Found in Application/Transfer/Import/Zwickau/Service.php - About 45 mins to fix

                        Method getPriceListByItemAndYear has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                TblItem $tblItem,
        $Year,
        $MonthFrom = '1',
        $MonthTo = '12',
        $DivisionId = '0',
                        Severity: Minor
                        Found in Application/Billing/Bookkeeping/Balance/Service.php - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                                  if (0 === strpos($phoneNumber, '01')) {
                                            $tblType = Phone::useService()->getTypeById(2);
                                        }
                          Severity: Major
                          Found in Application/Transfer/Import/Coswig/Service.php - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                                    if ($leaveSchool) {
                                            GroupCompany::useService()->addGroupCompany(
                                                GroupCompany::useService()->getGroupByMetaTable('COMMON'),
                                                $leaveSchool
                                            );
                            Severity: Major
                            Found in Application/Transfer/Import/Seelitz/Service.php - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                              if ($remark != '') {
                                    if (($tblCommon = $tblPerson->getCommon())) {
                                        Common::useService()->updateCommon($tblCommon, $tblCommon->getRemark() . "\n" . $remark);
                                    } else {
                                        Common::useService()->insertMeta(
                              Severity: Major
                              Found in Application/Transfer/Import/Braeunsdorf/Service.php - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                                    if ($infoNursery !== '') {
                                        $remarkCommon .= ($remarkCommon == '' ? '' : " \n") . 'Kindergarten: ' . $infoNursery;
                                    }
                                Severity: Major
                                Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                                      if (isset($nameArrayCustody1[0])) {
                                        $firstNameCustody1 = $nameArrayCustody1[0];
                                    }
                                  Severity: Major
                                  Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                                            if ($subjectReligion === 'ETH') {
                                            $tblSubject = Subject::useService()->getSubjectByAcronym('ETH');
                                        } elseif ($subjectReligion === 'RE/e') {
                                            $tblSubject = Subject::useService()->getSubjectByAcronym('RE/E');
                                        }
                                    Severity: Major
                                    Found in Application/Transfer/Import/BadDueben/Service.php - About 45 mins to fix

                                      Avoid deeply nested control flow statements.
                                      Open

                                                                              if ($tblPeriod) {
                                            Term::useService()->insertYearPeriod($tblYear, $tblPeriod);
                                        }
                                      Severity: Major
                                      Found in Application/Transfer/Import/Coswig/Service.php - About 45 mins to fix

                                        Avoid deeply nested control flow statements.
                                        Open

                                                                                if (!$tblPeriodList) {
                                            // firstTerm
                                            $tblPeriod = Term::useService()->insertPeriod(
                                                '1. Halbjahr',
                                                '01.08.20' . $year,
                                        Severity: Major
                                        Found in Application/Transfer/Import/Zwickau/Service.php - About 45 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language