DerDu/SPHERE-Framework

View on GitHub

Showing 5,014 of 7,620 total issues

Function createCompaniesFromFile has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

    public function createCompaniesFromFile(
        IFormInterface $Form = null,
        UploadedFile $File = null
    ) {

Severity: Minor
Found in Application/Transfer/Import/Zwickau/Service.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function filterDivisionSubjectList has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

    public function filterDivisionSubjectList(
        $tblDivisionSubjectList,
        TblYear $filterYear = null,
        TblType $filterType = null,
        TblLevel $filterLevel = null
Severity: Minor
Found in Application/Education/Graduation/Gradebook/Service.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function calcSubjectGradesAverageOthers has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

    private function calcSubjectGradesAverageOthers(TblPrepareStudent $tblPrepareStudent)
    {

        if (($tblCertificate = $tblPrepareStudent->getServiceTblCertificate())
            && ($tblPrepare = $tblPrepareStudent->getTblPrepareCertificate())
Severity: Minor
Found in Application/Education/Certificate/Prepare/Service.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Frontend.php has 537 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace SPHERE\Application\Platform\Gatekeeper\Authentication;

use SPHERE\Application\Education\Graduation\Evaluation\Evaluation;
Severity: Major
Found in Application/Platform/Gatekeeper/Authentication/Frontend.php - About 1 day to fix

    File Data.php has 536 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace SPHERE\Application\Billing\Bookkeeping\Basket\Service;
    
    use SPHERE\Application\Billing\Accounting\Creditor\Service\Entity\TblCreditor;
    Severity: Major
    Found in Application/Billing/Bookkeeping/Basket/Service/Data.php - About 1 day to fix

      File Data.php has 536 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      namespace SPHERE\Application\Education\Lesson\Term\Service;
      
      use SPHERE\Application\Corporation\Company\Service\Entity\TblCompany;
      use SPHERE\Application\Education\Lesson\Term\Service\Entity\TblHoliday;
      Severity: Major
      Found in Application/Education/Lesson/Term/Service/Data.php - About 1 day to fix

        Data has 61 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Data extends AbstractData
        {
        
            public function setupDatabaseContent()
            {
        Severity: Major
        Found in Application/Education/Certificate/Prepare/Service/Data.php - About 1 day to fix

          File GymKurshalbjahreszeugnis.php has 534 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          /**
           * Created by PhpStorm.
           * User: Kauschke
           * Date: 25.10.2017

            File AbstractStudentCard.php has 533 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            /**
             * Created by PhpStorm.
             * User: Kauschke
             * Date: 08.03.2017

              Method buildPages has 219 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function buildPages(TblPerson $tblPerson = null)
                  {
              
                      $personId = $tblPerson ? $tblPerson->getId() : 0;
              
              

                Method createClassList has 219 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function createClassList(TblDivision $tblDivision)
                    {
                
                        $tblPersonList = Division::useService()->getStudentAllByDivision($tblDivision);
                
                
                Severity: Major
                Found in Application/Reporting/Standard/Person/Service.php - About 1 day to fix

                  Function changeAccount has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function changeAccount(IFormInterface $Form, TblAccount $tblAccount, $Account)
                      {
                  
                          if (null === $Account) {
                  
                  
                  Severity: Minor
                  Found in Application/Setting/Authorization/Account/Service.php - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function importIndiwareStudentCourse has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function importIndiwareStudentCourse()
                      {
                  
                  //        $InfoList = array();
                          $tblIndiwareImportStudentList = $this->getIndiwareImportStudentAll(true);
                  Severity: Minor
                  Found in Application/Transfer/Indiware/Import/Service.php - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function copyAbiturPreliminaryGradesFromAppointedDateTask has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function copyAbiturPreliminaryGradesFromAppointedDateTask(
                          TblDivision $tblDivision,
                          TblPerson $tblPerson,
                          TblPrepareCertificate $tblPrepareCertificate,
                          TblPrepareAdditionalGradeType $tblPrepareAdditionalGradeType,
                  Severity: Minor
                  Found in Application/Education/Certificate/Prepare/Service.php - About 1 day to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File Frontend.php has 531 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  namespace SPHERE\Application\Education\Certificate\Generator;
                  
                  use SPHERE\Application\Document\Explorer\Storage\Storage;
                  use SPHERE\Application\Education\Certificate\Generator\Service\Entity\TblCertificate;
                  Severity: Major
                  Found in Application/Education/Certificate/Generator/Frontend.php - About 1 day to fix

                    Method setSelectStudentStage has 218 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function setSelectStudentStage(Stage $Stage, $DivisionId = null, $GroupId = null, $IsHeadmaster = false)
                        {
                    
                            $tblGroup = false;
                            $tblGroupTudor = Group::useService()->getGroupByMetaTable(TblGroup::META_TABLE_TUDOR);
                    Severity: Major
                    Found in Application/Education/Graduation/Gradebook/Frontend.php - About 1 day to fix

                      Method buildPages has 217 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function buildPages(TblPerson $tblPerson = null)
                          {
                      
                              $personId = $tblPerson ? $tblPerson->getId() : 0;
                      
                      

                        File Frontend.php has 528 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        namespace SPHERE\Application\Setting\Authorization\Account;
                        
                        use SPHERE\Application\People\Group\Group;
                        use SPHERE\Application\People\Person\Service\Entity\TblPerson;
                        Severity: Major
                        Found in Application/Setting/Authorization/Account/Frontend.php - About 1 day to fix

                          File Creator.php has 528 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          <?php
                          namespace SPHERE\Application\Api\Document;
                          
                          use MOC\V\Component\Document\Component\Parameter\Repository\PaperOrientationParameter;
                          use MOC\V\Component\Document\Document as PdfDocument;
                          Severity: Major
                          Found in Application/Api/Document/Creator.php - About 1 day to fix

                            File Frontend.php has 528 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            <?php
                            
                            namespace SPHERE\Application\People\Meta\Student;
                            
                            use SPHERE\Application\Api\People\Meta\Support\ApiSupport;
                            Severity: Major
                            Found in Application/People/Meta/Student/Frontend.php - About 1 day to fix
                              Severity
                              Category
                              Status
                              Source
                              Language