DerDu/SPHERE-Framework

View on GitHub

Showing 5,014 of 7,620 total issues

File Data.php has 527 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace SPHERE\Application\Contact\Address\Service;

use SPHERE\Application\Contact\Address\Service\Entity\TblAddress;
use SPHERE\Application\Contact\Address\Service\Entity\TblCity;
Severity: Major
Found in Application/Contact/Address/Service/Data.php - About 1 day to fix

    File Service.php has 527 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * Created by PhpStorm.
     * User: Kauschke
     * Date: 07.06.2018
    Severity: Major
    Found in Application/Education/Lesson/Division/Filter/Service.php - About 1 day to fix

      Method buildPages has 216 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function buildPages(TblPerson $tblPerson = null)
          {
              $personId = $tblPerson ? $tblPerson->getId() : 0;
      
              $Header = $this->getHead($this->isSample(), true, 'auto', '50px');

        Method setGradeOverviewForTask has 216 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function setGradeOverviewForTask(
                TblTask $tblTask,
                $divisionList,
                $tableHeaderList,
                $studentList,
        Severity: Major
        Found in Application/Education/Graduation/Evaluation/Frontend.php - About 1 day to fix

          Method frontendPrepareDiplomaAbiturPreview has 215 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontendPrepareDiplomaAbiturPreview($PrepareId = null, $GroupId = null)
              {
          
                  $stage = new Stage('Zeugnisvorbereitungen', 'Übersicht');
          
          
          Severity: Major
          Found in Application/Education/Certificate/Prepare/Abitur/Frontend.php - About 1 day to fix

            Function getIsFulfilledButNotInGroupByPerson has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getIsFulfilledButNotInGroupByPerson(
                    TblPerson $tblPerson,
                    TblSubject $tblSubject,
                    TblSubjectGroup $tblSubjectGroup,
                    TblDivisionSubject $tblDivisionSubject,
            Severity: Minor
            Found in Application/Education/Lesson/Division/Filter/Filter.php - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function innerJoin has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function innerJoin($List)
                {
                    $Result = array();
                    /** @var AbstractView $Node0 */
                    foreach ($List[0] as $Node0) {
            Severity: Minor
            Found in System/Database/Filter/Link/Repository/Node5.php - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function setCoursesMatrix has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function setCoursesMatrix(
                    &$Content,
                    $personAdvancedCourseList
                ) {
            
            
            Severity: Minor
            Found in Application/Document/Generator/Service/Kamenz/KamenzReportService.php - About 1 day to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method createStaffsFromFile has 214 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function createStaffsFromFile(IFormInterface $Form = null, UploadedFile $File = null)
                {
            
                    /**
                     * Skip to Frontend
            Severity: Major
            Found in Application/Transfer/Import/Radebeul/Service.php - About 1 day to fix

              Method getBasketVerificationLayout has 214 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function getBasketVerificationLayout($BasketId = null)
                  {
              
                      $tblBasket = Basket::useService()->getBasketById($BasketId);
                      if(!$tblBasket){
              Severity: Major
              Found in Application/Billing/Bookkeeping/Basket/Frontend.php - About 1 day to fix

                Method registerModule has 214 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function registerModule()
                    {
                
                        /**
                         * Navigation
                Severity: Major
                Found in Application/Education/Graduation/Gradebook/Gradebook.php - About 1 day to fix

                  File Service.php has 523 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  /**
                   * Created by PhpStorm.
                   * User: Kauschke
                   * Date: 04.01.2017
                  Severity: Major
                  Found in Application/Transfer/Import/Schulstiftung/Service.php - About 1 day to fix

                    File Service.php has 521 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    /**
                     * Created by PhpStorm.
                     * User: Kauschke
                     * Date: 25.11.2016
                    Severity: Major
                    Found in Application/Education/Certificate/Generate/Service.php - About 1 day to fix

                      Method buildPages has 212 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function buildPages(TblPerson $tblPerson = null)
                          {
                      
                              $personId = $tblPerson ? $tblPerson->getId() : 0;
                      
                      
                      Severity: Major
                      Found in Application/Api/Education/Certificate/Generator/Repository/MsAbg.php - About 1 day to fix

                        Method frontendDashboard has 212 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function frontendDashboard()
                            {
                        
                                $Stage = new Stage('Datenschutzerklärung Schulsoftware');
                        
                        
                        Severity: Major
                        Found in Application/Document/DataProtectionOrdinance.php - About 1 day to fix

                          Method formFilterPdf has 211 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              private function formFilterPdf($GroupByTime, $IsParent = false, $Data = null)
                              {
                          
                                  $SelectBoxContent = array();
                          
                          
                          Severity: Major
                          Found in Application/Api/Setting/UserAccount/ApiUserAccount.php - About 1 day to fix

                            Method getSubjectLanesCoswig has 211 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                protected function getSubjectLanesCoswig(
                                    $personId,
                                    $isSlice = true,
                                    $languagesWithStartLevel = array(),
                                    $TextSize = '14px',
                            Severity: Major
                            Found in Application/Api/Education/Certificate/Generator/Certificate.php - About 1 day to fix

                              Method getDivisionSelectedStage has 211 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function getDivisionSelectedStage(Stage $Stage, $DivisionId, $isTeacher = false)
                                  {
                              
                                      $tblDivision = Division::useService()->getDivisionById($DivisionId);
                                      if ($tblDivision) {
                              Severity: Major
                              Found in Application/Education/ClassRegister/ClassRegister.php - About 1 day to fix

                                Function getStudentsWithoutDivision has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public static function getStudentsWithoutDivision(&$count = 0)
                                    {
                                
                                        $personList = array();
                                        if (($tblGroup = Group::useService()->getGroupByMetaTable('STUDENT'))
                                Severity: Minor
                                Found in Application/Reporting/KamenzReport/KamenzService.php - About 1 day to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Function frontendSetupFilter has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function frontendSetupFilter($DynamicFilter = 0, $DynamicFilterMask = null, $FilterFieldName = null)
                                    {
                                
                                        $Stage = new Stage('Flexible Auswertung', 'Filter definieren');
                                        $Stage->setMessage('');
                                Severity: Minor
                                Found in Application/Reporting/Dynamic/Frontend.php - About 1 day to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language