Sign upLogin

Dhii/collections-abstract-base

View on GitHub
Star

Showing 5 of 62 total issues

AbstractCollection has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class AbstractCollection extends AbstractHasher implements CollectionInterface
{
    protected $items;

    /**
Severity: Minor
Found in src/AbstractCollection.php - About 2 hrs to fix

    Function _arraySearch has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _arraySearch(&$array, $value, $strict = false)
    {
        // Regular array matching
        if (is_array($array)) {
            return array_search($value, $array, $strict);
    Severity: Minor
    Found in src/AbstractCollection.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _arrayUnset has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _arrayUnset(&$array, $key)
    {
        if (is_array($array)) {
            if (isset($array[$key])) {
                unset($array[$key]);
    Severity: Minor
    Found in src/AbstractCollection.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return false;
    Severity: Major
    Found in src/AbstractCollection.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return $array->removeItemByKey($key);
      Severity: Major
      Found in src/AbstractCollection.php - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language