Sign upLogin

Dhii/simple-test-abstract

View on GitHub
Star

Showing 9 of 160 total issues

AbstractStatefulTester has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class AbstractStatefulTester extends AbstractTester
{
    /** @var Writer\WriterInterface */
    protected $writer;
    /** @var Stats\AggregatorInterface */
Severity: Minor
Found in src/Tester/AbstractStatefulTester.php - About 2 hrs to fix

    Method _runTest has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _runTest(Test\TestBaseInterface $test)
    {
        $assertionMaker  = $this->_getAssertionMaker();
        $countAssertions = $assertionMaker instanceof Assertion\AccountableInterface;
        if ($countAssertions) {
    Severity: Major
    Found in src/Runner/AbstractRunner.php - About 2 hrs to fix

      Method _resolvePathSpec has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function _resolvePathSpec($paths)
    {
        $resolved = array();

        // Strings treaded as file patterns, but existing file paths treated literally
      Severity: Minor
      Found in src/Locator/AbstractFilePathLocator.php - About 1 hr to fix

        Method _getCalculators has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function _getCalculators()
    {
        return array(
            'assertion_count' => function ($totals, $code, $source) {
                if ($source instanceof Assertion\AccountableInterface) {
        Severity: Minor
        Found in src/Test/AbstractAggregator.php - About 1 hr to fix

          Function _resolvePathSpec has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function _resolvePathSpec($paths)
    {
        $resolved = array();

        // Strings treaded as file patterns, but existing file paths treated literally
          Severity: Minor
          Found in src/Locator/AbstractFilePathLocator.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method _createResultFromTest has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              abstract protected function _createResultFromTest(Test\TestBaseInterface $test, $message, $status, $assertionCount, $runnerCode, $time, $memory);
          Severity: Major
          Found in src/Runner/AbstractRunner.php - About 50 mins to fix

            Method _processTestResult has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                protected function _processTestResult(Test\TestBaseInterface $test, $status, $message, $assertionCount, $time, $memory)
            Severity: Minor
            Found in src/Runner/AbstractRunner.php - About 45 mins to fix

              Function _getCalculators has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function _getCalculators()
    {
        return array(
            'assertion_count' => function ($totals, $code, $source) {
                if ($source instanceof Assertion\AccountableInterface) {
              Severity: Minor
              Found in src/Test/AbstractAggregator.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _getFilePaths has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function _getFilePaths()
    {
        $results = array();
        foreach ($this->_getPathsSpecs() as $_pathExpr) {
            $paths = $this->_resolvePathSpec($_pathExpr);
              Severity: Minor
              Found in src/Locator/AbstractFilePathLocator.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language