Sign upLogin

DishDelish/dishdelish-app

View on GitHub
Star

Showing 36 of 120 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            } else {
                currentComment.decreaseLikes();
                database.updateAsync(recipe)
                        .addOnSuccessListener(s -> {
                            // change background
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/CommentViewHolder.java and 1 other location - About 1 hr to fix
app/src/main/java/com/github/siela1915/bootcamp/CommentViewHolder.java on lines 109..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                } else {
                    currentComment.increaseLikes();
                    database.updateAsync(recipe)
                            .addOnSuccessListener(arg -> {
                                buttonView.setBackground(getDrawable(itemView.getContext(), R.drawable.ic_thumb_full));
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/CommentViewHolder.java and 1 other location - About 1 hr to fix
app/src/main/java/com/github/siela1915/bootcamp/CommentViewHolder.java on lines 130..153

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 112.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (filterLanguage) {
            String filtered = filterLanguage(comment.getContent());
            if (comment.getReplies().size() == 0) {
                return new Comment(comment.getLikes(), filtered, new LinkedList<>());
            }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/LanguageFilter.java and 1 other location - About 1 hr to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/LanguageFilter.java on lines 455..465

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        } else {
            String filtered = filterSingleWords(comment.getContent());
            if (comment.getReplies().size() == 0) {
                return new Comment(comment.getLikes(), filtered, new LinkedList<>());
            }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/LanguageFilter.java and 1 other location - About 1 hr to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/LanguageFilter.java on lines 445..455

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            database.addFavorite(recipe.uniqueKey).addOnSuccessListener(arg -> {
                // Show a success message to the user
                Toast.makeText(this, "Recipe added to favorites", Toast.LENGTH_SHORT).show();

                //change background
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java and 1 other location - About 55 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java on lines 327..340

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            database.removeFavorite(recipe.uniqueKey).addOnSuccessListener(s -> {

                // display success message
                Toast.makeText(this, "Recipe removed from favorites", Toast.LENGTH_SHORT).show();
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java and 1 other location - About 55 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/RecipeActivity.java on lines 301..312

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static DietType getDominantDiet(List<Recipe> ls) {
        int[] arr = new int[DietType.values().length];
        for (Recipe elem : ls) {
            elem.getDietTypes().forEach(diet -> ++arr[diet]);
        }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java and 2 other locations - About 50 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 89..95
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 117..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static AllergyType getDominantAllergy(List<Recipe> ls) {
        int[] arr = new int[AllergyType.values().length];
        for (Recipe elem : ls) {
            elem.getAllergyTypes().forEach(allergy -> ++arr[allergy]);
        }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java and 2 other locations - About 50 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 103..109
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 117..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static CuisineType getDominantCuisine(List<Recipe> ls) {
        int[] arr = new int[CuisineType.values().length];
        for (Recipe elem : ls) {
            elem.getCuisineTypes().forEach(cuisine -> ++arr[cuisine]);
        }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java and 2 other locations - About 50 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 89..95
app/src/main/java/com/github/siela1915/bootcamp/Tools/Utilities.java on lines 103..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public CommentAdapter(Context context, List<Comment> comments, Recipe recipe) {
        this.context = context;
        this.comments = comments;
        this.recipe = recipe;
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/CommentAdapter.java and 1 other location - About 45 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/ReplyAdapter.java on lines 25..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public ReplyAdapter(Context context, List<Comment> replies, Comment parent){
        this.context = context;
        this.replies = replies;
        this.parent = parent;
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/ReplyAdapter.java and 1 other location - About 45 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/CommentAdapter.java on lines 28..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            || (DietType.fromIntList(diets)).stream()
                    .distinct()
                    .filter(x -> (DietType.fromIntList(r.dietTypes)).stream().anyMatch(y -> y.equals(x)))
                    .toArray().length > 0
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java and 1 other location - About 40 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 62..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            || (AllergyType.fromIntList(allergies)).stream()
                    .distinct()
                    .filter(x -> (AllergyType.fromIntList(r.allergyTypes)).stream().anyMatch(y -> y.equals(x)))
                    .toArray().length > 0
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java and 1 other location - About 40 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 66..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        userDb.getUser(comments.get(position).getUserId()).addOnSuccessListener(user -> {
            holder.userName.setText(user.getDisplayName());
            new DownloadImageTask(holder.photo).execute(user.getPhotoUrl());
        });
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/CommentAdapter.java and 1 other location - About 35 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/ReplyAdapter.java on lines 53..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        userDb.getUser(replies.get(position).getUserId()).addOnSuccessListener(user -> {
            holder.userName.setText(user.getDisplayName());
            new DownloadImageTask(holder.photo).execute(user.getPhotoUrl());
        });
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/ReplyAdapter.java and 1 other location - About 35 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/CommentAdapter.java on lines 49..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public List<String> sortByCalories(List<Recipe> recipes) {
        Objects.requireNonNull(recipes);
        return recipes.stream().sorted(Comparator.comparingDouble(Recipe::getCalories)).map(r -> r.uniqueKey).collect(Collectors.toList());
    }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java and 4 other locations - About 35 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 140..143
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 150..153
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 160..163
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 180..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static NearbyHelpFragment newInstance(List<Ingredient> askedIngredients) {
        NearbyHelpFragment fragment = new NearbyHelpFragment();
        Bundle args = new Bundle();
        args.putParcelableArrayList(ARG_ASKED_INGREDIENTS, new ArrayList<>(askedIngredients));
        fragment.setArguments(args);
Severity: Minor
Found in app/src/main/java/com/github/siela1915/bootcamp/NearbyHelpFragment.java and 2 other locations - About 35 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/HomePageFragment.java on lines 90..96
app/src/main/java/com/github/siela1915/bootcamp/RecipeListFragment.java on lines 36..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public List<String> sortByProtein(List<Recipe> recipes) {
        Objects.requireNonNull(recipes);
        return recipes.stream().sorted(Comparator.comparingDouble(Recipe::getProtein)).map(r -> r.uniqueKey).collect(Collectors.toList());
    }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java and 4 other locations - About 35 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 150..153
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 160..163
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 170..173
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 180..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public List<String> sortBySugar(List<Recipe> recipes) {
        Objects.requireNonNull(recipes);
        return recipes.stream().sorted(Comparator.comparingDouble(Recipe::getSugar)).map(r -> r.uniqueKey).collect(Collectors.toList());
    }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java and 4 other locations - About 35 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 140..143
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 150..153
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 160..163
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 170..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    public List<String> sortByFat(List<Recipe> recipes) {
        Objects.requireNonNull(recipes);
        return recipes.stream().sorted(Comparator.comparingDouble(Recipe::getFat)).map(r -> r.uniqueKey).collect(Collectors.toList());
    }
Severity: Major
Found in app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java and 4 other locations - About 35 mins to fix
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 140..143
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 160..163
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 170..173
app/src/main/java/com/github/siela1915/bootcamp/Labelling/RecipeFetcher.java on lines 180..183

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language