Sign upLogin

DmytroStepaniuk/api_session_recovering

View on GitHub
Star

Showing 3 of 5 total issues

Method save! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def save!
    #
    # Save every password reset request.
    # We allow certain amount of reqeusts per day.
    #
Severity: Minor
Found in app/services/api_session_recovering/reset_password_service.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_reset_password_attempts_via_email_count has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_reset_password_attempts_via_email_count
    #
    # dont validate if no `remote_ip`
    #
    unless Rails.env.test?
Severity: Minor
Found in lib/validators/reset_password_attempts_validation.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_reset_password_attempts_via_phone_count has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_reset_password_attempts_via_phone_count
    #
    # dont validate if no `remote_ip`
    #
    unless Rails.env.test?
Severity: Minor
Found in lib/validators/reset_password_attempts_validation.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language