Sign upLogin

DoubleCheck/log-ship-elastic-qpsmtpd

View on GitHub
Star

Showing 7 of 7 total issues

Function QpsmtpdToElastic has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function QpsmtpdToElastic (etcDir) {
  var qp2e = this;
  qp2e.cfg = config(etcDir);
  assert.ok(qp2e.cfg);
Severity: Minor
Found in lib/logship.js - About 1 hr to fix

    Function exports has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(grunt) {

  grunt.loadNpmTasks('grunt-eslint');
  grunt.loadNpmTasks('grunt-mocha-test');
  grunt.loadNpmTasks('grunt-version-check');
    Severity: Minor
    Found in Gruntfile.js - About 1 hr to fix

      Function saveToEs has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      QpsmtpdToElastic.prototype.saveToEs = function(done) {
  var qp2e = this;

  if (qp2e.queueActive === true) {
    return done ('queue already active!');
      Severity: Minor
      Found in lib/logship.js - About 1 hr to fix

        Function saveToEs has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        QpsmtpdToElastic.prototype.saveToEs = function(done) {
  var qp2e = this;

  if (qp2e.queueActive === true) {
    return done ('queue already active!');
        Severity: Minor
        Found in lib/logship.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function isValidDir has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.isValidDir = function (dir, done) {

  if (!done) {
    if (this.isDirectory(dir) && this.isWritable(dir)) {
      return true;
        Severity: Minor
        Found in lib/spool.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function isWritable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.isWritable = function (dir, done) {
  if (!fs.access) { return this.isWritablePreV12(dir, done); }
  if (!done) {
    try {
      fs.accessSync(dir, fs.W_OK);
        Severity: Minor
        Found in lib/spool.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function loadConfig has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function loadConfig (etcDir) {
  var file = 'log-ship-elastic-qpsmtpd.ini';
  var candidates = [];
  if (etcDir) candidates.push(path.resolve(etcDir, file));
  if (etcDir !== '/etc') {
        Severity: Minor
        Found in lib/config.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language