Sign upLogin

DoubleCheck/log-ship-elastic-qpsmtpd

View on GitHub
Star
lib/logship.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function QpsmtpdToElastic has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function QpsmtpdToElastic (etcDir) {
  var qp2e = this;
  qp2e.cfg = config(etcDir);
  assert.ok(qp2e.cfg);
Severity: Minor
Found in lib/logship.js - About 1 hr to fix

    Function saveToEs has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    QpsmtpdToElastic.prototype.saveToEs = function(done) {
  var qp2e = this;

  if (qp2e.queueActive === true) {
    return done ('queue already active!');
    Severity: Minor
    Found in lib/logship.js - About 1 hr to fix

      Function saveToEs has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      QpsmtpdToElastic.prototype.saveToEs = function(done) {
  var qp2e = this;

  if (qp2e.queueActive === true) {
    return done ('queue already active!');
      Severity: Minor
      Found in lib/logship.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status