Sign upLogin

Drosty/truegm

View on GitHub
Star

Showing 7 of 27 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def col4_for_header header_category, year, week
    val = 0
    if is_passing_header?(header_category)
      stat = @player.passing_stats.where({season: year, week: week}).first
      val = stat.passing_interceptions if stat
Severity: Major
Found in app/models/nfl_player_view_model.rb and 2 other locations - About 2 hrs to fix
app/models/nfl_player_view_model.rb on lines 56..80
app/models/nfl_player_view_model.rb on lines 83..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def col2_for_header header_category, year, week
    val = 0
    if is_passing_header?(header_category)
      stat = @player.passing_stats.where({season: year, week: week}).first
      val = stat.passing_yards if stat
Severity: Major
Found in app/models/nfl_player_view_model.rb and 2 other locations - About 2 hrs to fix
app/models/nfl_player_view_model.rb on lines 83..108
app/models/nfl_player_view_model.rb on lines 111..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  def col3_for_header header_category, year, week
    val = 0
    if is_passing_header?(header_category)
      stat = @player.passing_stats.where({season: year, week: week}).first
      val = stat.passing_touchdowns if stat
Severity: Major
Found in app/models/nfl_player_view_model.rb and 2 other locations - About 2 hrs to fix
app/models/nfl_player_view_model.rb on lines 56..80
app/models/nfl_player_view_model.rb on lines 111..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 88.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    def process_rushing_stat stat_info, week, season
      player = NflPlayer.find_by(fantasy_data_id: stat_info.player_id)
      return if player.nil?
      db_stat = RushingStat.find_or_create_by({nfl_player_id: player.id, week: week, season: season})
Severity: Minor
Found in app/services/fantasy_data/stat_import_processing.rb and 3 other locations - About 25 mins to fix
app/services/fantasy_data/stat_import_processing.rb on lines 53..59
app/services/fantasy_data/stat_import_processing.rb on lines 71..77
app/services/fantasy_data/stat_import_processing.rb on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    def process_passing_stat stat_info, week, season
      player = NflPlayer.find_by(fantasy_data_id: stat_info.player_id)
      return if player.nil?
      db_stat = PassingStat.find_or_create_by({nfl_player_id: player.id, week: week, season: season})
Severity: Minor
Found in app/services/fantasy_data/stat_import_processing.rb and 3 other locations - About 25 mins to fix
app/services/fantasy_data/stat_import_processing.rb on lines 62..68
app/services/fantasy_data/stat_import_processing.rb on lines 71..77
app/services/fantasy_data/stat_import_processing.rb on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    def process_receiving_stat stat_info, week, season
      player = NflPlayer.find_by(fantasy_data_id: stat_info.player_id)
      return if player.nil?
      db_stat = ReceivingStat.find_or_create_by({nfl_player_id: player.id, week: week, season: season})
Severity: Minor
Found in app/services/fantasy_data/stat_import_processing.rb and 3 other locations - About 25 mins to fix
app/services/fantasy_data/stat_import_processing.rb on lines 53..59
app/services/fantasy_data/stat_import_processing.rb on lines 62..68
app/services/fantasy_data/stat_import_processing.rb on lines 80..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    def process_kicking_stat stat_info, week, season
      player = NflPlayer.find_by(fantasy_data_id: stat_info.player_id)
      return if player.nil?
      db_stat = KickingStat.find_or_create_by({nfl_player_id: player.id, week: week, season: season})
Severity: Minor
Found in app/services/fantasy_data/stat_import_processing.rb and 3 other locations - About 25 mins to fix
app/services/fantasy_data/stat_import_processing.rb on lines 53..59
app/services/fantasy_data/stat_import_processing.rb on lines 62..68
app/services/fantasy_data/stat_import_processing.rb on lines 71..77

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language