Sign upLogin

EOL-Labs/mely

View on GitHub
Star
lib/theme.js

Summary

Maintainability
D
1 day
Test Coverage

File theme.js has 286 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var models = require("./models");
var glob = require("glob");
var changeCase = require("change-case");
var fs = require("fs");
var internals = {};
Severity: Minor
Found in lib/theme.js - About 2 hrs to fix

    Function updateTheme has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    internals.updateTheme = function(input, callback){
    var errorMessages = [];
    var id = input.id;
    var name = input.name;
    var description = input.description;
    Severity: Major
    Found in lib/theme.js - About 2 hrs to fix

      Function createTheme has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      internals.createTheme = function(input, callback){
    var errorMessages = [];
    var systemid = input.systemid;
    var name = input.name;
    var description = input.description;
      Severity: Major
      Found in lib/theme.js - About 2 hrs to fix

        Function activateTheme has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        internals.activateTheme = function(input, callback){
    var errorMessages = [];
    var id = input.id;
    var systemid = input.systemid;
    if (systemid === undefined){
        Severity: Minor
        Found in lib/theme.js - About 1 hr to fix

          Function getTheme has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          internals.getTheme = function(input, callback){
    var errorMessages = [];
    var id = input.id;
    var systemid = input.systemid;
    var active = input.active;
          Severity: Minor
          Found in lib/theme.js - About 1 hr to fix

            Function getTheme has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            internals.getTheme = function(input, callback){
    var errorMessages = [];
    var id = input.id;
    var systemid = input.systemid;
    var active = input.active;
            Severity: Minor
            Found in lib/theme.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    for(var file in files){
            var fileObj = {};
            fileObj.name = changeCase.titleCase(files[file].replace("lib/views/mely/","").replace(".html",""));
            fileList.push(fileObj);
        }
            Severity: Major
            Found in lib/theme.js and 1 other location - About 1 hr to fix
            lib/theme.js on lines 233..237

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if(files[file].indexOf("blog-") !== -1){
                    var fileObj = {};
                    fileObj.name = changeCase.titleCase(files[file].replace("lib/views/partials/mely/","").replace(".html",""));
                    fileList.push(fileObj);
                }
            Severity: Major
            Found in lib/theme.js and 1 other location - About 1 hr to fix
            lib/theme.js on lines 226..230

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    models.Theme.find({
            where:{
                id: id,
                SystemId: systemid
            }
            Severity: Minor
            Found in lib/theme.js and 1 other location - About 35 mins to fix
            lib/user.js on lines 49..59

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status