Showing 30 of 34 total issues
Method __construct
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
EntityFactoryInterface $entityFactory,
LoggerInterface $logger,
FetchStrategyInterface $fetchStrategy,
ManagerInterface $eventManager,
StoreManagerInterface $storeManager,
Method __construct
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
$name,
$primaryFieldName,
$requestFieldName,
templateCollectionFactory $templateCollectionFactory,
DataPersistorInterface $dataPersistor,
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
ContextInterface $context,
UiComponentFactory $uiComponentFactory,
UrlInterface $urlBuilder,
array $components = [],
array $data = [],
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
Context $context,
StoreManagerInterface $storeManager,
DateTime $dateTime,
EntityManager $entityManager,
MetadataPool $metadataPool,
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
Template $templateContainer,
IdentityInterface $identityContainer,
TransportBuilder $transportBuilder,
Pdf $helper,
Data $dataHelper,
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
Action\Context $context,
PdfDataProcessor $dataProcessor,
DataPersistorInterface $dataPersistor,
TemplateRepository $templateRepository,
PdfgeneratorFactory $pdfgeneratorFactory
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
Context $context,
PageFactory $resultPageFactory,
Registry $registry,
TemplateRepository $templateRepository,
PdfgeneratorFactory $pdfgeneratorFactory
Avoid too many return
statements within this method. Open
Open
return $resultRedirect->setPath('*/*/');
Avoid too many return
statements within this method. Open
Open
return $this->fileFactory->create(
$fileName,
$pdfFileData['filestream'],
DirectoryList::VAR_DIR,
'application/pdf'
Function prepareDataSource
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
public function prepareDataSource(array $dataSource)
{
if (isset($dataSource['data']['items'])) {
foreach ($dataSource['data']['items'] as & $item) {
$name = $this->getData('name');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"