Sign upLogin

Easybuoy/storemanager

View on GitHub
Star
server/controllers/saleController.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function createSale has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static createSale(req, res) {
    const processSale = (order) => {
      let isMoreThanStock = false;
      let isNotProductAvailable = false;
      let totalSalesAmount = 0;
Severity: Major
Found in server/controllers/saleController.js - About 2 hrs to fix

    Function processSale has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const processSale = (order) => {
      let isMoreThanStock = false;
      let isNotProductAvailable = false;
      let totalSalesAmount = 0;
      order.map((ordertobeprocessed) => {
    Severity: Minor
    Found in server/controllers/saleController.js - About 1 hr to fix

      Function getSaleById has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        static getSaleById(req, res) {
    // check if user making the request is the Store Owner / Admin

    if (!Number(req.user.type) === 1 || !Number(req.user.type) === 3) {
      return res.status(401).json({ message: 'Unauthorized' });
      Severity: Minor
      Found in server/controllers/saleController.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createSale has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        static createSale(req, res) {
    const processSale = (order) => {
      let isMoreThanStock = false;
      let isNotProductAvailable = false;
      let totalSalesAmount = 0;
      Severity: Minor
      Found in server/controllers/saleController.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status