Sign upLogin

Ed-ITSolutions/KashflowAPI

View on GitHub
Star

Showing 9 of 13 total issues

Method build_arguments has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def self.build_arguments(action, object, field, argument)
      if action == "get"
        expects argument, String
        return "<Quote#{field}>#{argument}</Quote#{field}>" if object == "quote"
      elsif action == "update" || action == "insert"
Severity: Minor
Found in lib/kashflow_api/models/quote.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_arguments has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def self.build_arguments(action, object, field, argument)
      if action == "get"
        expects argument, String
        return "<Supplier#{field}>#{argument}</Supplier#{field}>" if object == "supplier"
        return "<#{field}>#{argument}</#{field}>" if object == "suppliers"
Severity: Minor
Found in lib/kashflow_api/models/supplier.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_arguments has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def self.build_arguments(action, object, field, argument)
      if action == "get"
        expects argument, String
        return "<ReceiptNumber>#{argument}</ReceiptNumber>" if object == "receipt"
      elsif action == "update" || action == "insert"
Severity: Minor
Found in lib/kashflow_api/models/receipt.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_arguments has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def self.build_arguments(action, object, field, argument)
        if action == "get"
          expects argument, String
          return "<InvoiceNumber>#{argument}</InvoiceNumber>" if object == "invoice"
        elsif action == "update" || action == "insert"
Severity: Minor
Found in lib/kashflow_api/models/invoice.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_arguments has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def self.build_arguments(action, object, field, argument)
      if action == "get"
        expects argument, String
        return "<Customer#{field}>#{argument}</Customer#{field}>" if object == "customer"
        return "<#{field}>#{argument}</#{field}>" if object == "customers"
Severity: Minor
Found in lib/kashflow_api/models/customer.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_xml has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

      def to_xml
        xml = []
        id_line = ""
        @hash.keys.each do |key|
          if key == "LineID"
Severity: Minor
Found in lib/kashflow_api/models/line.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_xml has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def to_xml
        xml = []
        id_line = ""
        @hash.keys.each do |key|
            if key == self.class::XMLKey
Severity: Minor
Found in lib/kashflow_api/soap_object.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return KashflowApi::Supplier.build_arguments(@action, @object, @field, argument)
Severity: Major
Found in lib/kashflow_api/api_call.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return ""
    Severity: Major
    Found in lib/kashflow_api/api_call.rb - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language