Sign upLogin

EdgarOrtegaRamirez/lita-team

View on GitHub
Star

Showing 6 of 6 total issues

Method remove has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def remove(response)
        team_name = response.match_data[1]
        if team = get_team(team_name)
          if team[:limit] && team[:limit] <= team[:members].count
            return response.reply(
Severity: Minor
Found in lib/lita/handlers/remove_member_from_team.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method remove has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def remove(response)
        team_name = response.match_data[1]
        if team = get_team(team_name)
          if team[:limit] && team[:limit] <= team[:members].count
            return response.reply(
Severity: Minor
Found in lib/lita/handlers/remove_member_from_team.rb - About 1 hr to fix

    Method add has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def add(response)
        team_name = response.match_data[1]
        if team = get_team(team_name)
          if team[:limit] && team[:limit] <= team[:members].count
            return response.reply(
    Severity: Minor
    Found in lib/lita/handlers/add_member_to_team.rb - About 1 hr to fix

      Method confirm has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def confirm(response)
        team_name = response.match_data[1]
        if team = get_team(team_name)
          member_name = (response.match_data[3] ||
                         response.user.mention_name).delete("@")
      Severity: Minor
      Found in lib/lita/handlers/confirm_member.rb - About 1 hr to fix

        Method add has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def add(response)
        team_name = response.match_data[1]
        if team = get_team(team_name)
          if team[:limit] && team[:limit] <= team[:members].count
            return response.reply(
        Severity: Minor
        Found in lib/lita/handlers/add_member_to_team.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method confirm has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def confirm(response)
        team_name = response.match_data[1]
        if team = get_team(team_name)
          member_name = (response.match_data[3] ||
                         response.user.mention_name).delete("@")
        Severity: Minor
        Found in lib/lita/handlers/confirm_member.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language