Emapic/emapic

View on GitHub
utils.js

Summary

Maintainability
F
5 days
Test Coverage

Function exports has a Cognitive Complexity of 128 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function(app) {
    Utils = {
        encryptSurveyId: function(id) {
            return (id) ? bases.toBase(id * surveyIdEncr.factor, surveyIdEncr.base ) : null;
        },
Severity: Minor
Found in utils.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 292 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(app) {
    Utils = {
        encryptSurveyId: function(id) {
            return (id) ? bases.toBase(id * surveyIdEncr.factor, surveyIdEncr.base ) : null;
        },
Severity: Major
Found in utils.js - About 1 day to fix

    File utils.js has 422 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // utils.js/
    var nodemailer = require('nodemailer'),
        fs = require('fs'),
        nconf = require('nconf'),
        Promise = require('bluebird'),
    Severity: Minor
    Found in utils.js - About 6 hrs to fix

      Function paginationTemplate has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              paginationTemplate: function(elementName) {
                  return function(result) {
                      function getPrevNextLink(prelink, url, next) {
                          return '<li class="pagination-' + (next ? 'next' : 'previous') + (url ? '' : ' disabled') + '"><a' + (url ? ' href="' + prelink + url + '"' : '') + '><span class="glyphicon glyphicon-menu-' + (next ? 'right' : 'left') + '"></span></a></li>';
                      }
      Severity: Minor
      Found in utils.js - About 1 hr to fix

        Function takeSnapshot has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                takeSnapshot: function(url, imgPath, nativeWidth, nativeHeight, wait, minSize, retries, imgWidth, imgHeight) {
        Severity: Major
        Found in utils.js - About 1 hr to fix

          Function transformImage has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  transformImage: function(input, width, height, upscale, format, outputFile) {
                      var imgFormat = format ? format : null;
                      if (sharp) {
                          if (imgFormat && imgFormat.lastIndexOf('image/') === 0) {
                              imgFormat = imgFormat.replace('image/', '');
          Severity: Minor
          Found in utils.js - About 1 hr to fix

            Function takeSnapshotRaw has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function takeSnapshotRaw(url, imgPath, width, height, wait, minSize, tries) {
            Severity: Major
            Found in utils.js - About 50 mins to fix

              Function transformImage has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      transformImage: function(input, width, height, upscale, format, outputFile) {
              Severity: Minor
              Found in utils.js - About 45 mins to fix

                Function getPaginationHtml has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        getPaginationHtml: function(req, pageNr, pageSize, totalResults, elementName) {
                Severity: Minor
                Found in utils.js - About 35 mins to fix

                  Function transformImageSharp has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function transformImageSharp(input, width, height, upscale, format) {
                  Severity: Minor
                  Found in utils.js - About 35 mins to fix

                    Function transformImageJimp has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function transformImageJimp(input, width, height, upscale, format) {
                    Severity: Minor
                    Found in utils.js - About 35 mins to fix

                      Unnecessary semicolon.
                      Open

                      };
                      Severity: Minor
                      Found in utils.js by eslint

                      disallow unnecessary semicolons (no-extra-semi)

                      Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

                      Rule Details

                      This rule disallows unnecessary semicolons.

                      Examples of incorrect code for this rule:

                      /*eslint no-extra-semi: "error"*/
                      
                      var x = 5;;
                      
                      function foo() {
                          // code
                      };

                      Examples of correct code for this rule:

                      /*eslint no-extra-semi: "error"*/
                      
                      var x = 5;
                      
                      var foo = function() {
                          // code
                      };

                      When Not To Use It

                      If you intentionally use extra semicolons then you can disable this rule.

                      Related Rules

                      Unexpected require().
                      Open

                          Jimp = require('jimp');
                      Severity: Minor
                      Found in utils.js by eslint

                      Enforce require() on the top-level module scope (global-require)

                      In Node.js, module dependencies are included using the require() function, such as:

                      var fs = require("fs");

                      While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

                      function foo() {
                      
                          if (condition) {
                              var fs = require("fs");
                          }
                      }

                      Since require() does a synchronous load, it can cause performance problems when used in other locations.

                      Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

                      Rule Details

                      This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

                      Examples of incorrect code for this rule:

                      /*eslint global-require: "error"*/
                      /*eslint-env es6*/
                      
                      // calling require() inside of a function is not allowed
                      function readFile(filename, callback) {
                          var fs = require('fs');
                          fs.readFile(filename, callback)
                      }
                      
                      // conditional requires like this are also not allowed
                      if (DEBUG) { require('debug'); }
                      
                      // a require() in a switch statement is also flagged
                      switch(x) { case '1': require('1'); break; }
                      
                      // you may not require() inside an arrow function body
                      var getModule = (name) => require(name);
                      
                      // you may not require() inside of a function body as well
                      function getModule(name) { return require(name); }
                      
                      // you may not require() inside of a try/catch block
                      try {
                          require(unsafeModule);
                      } catch(e) {
                          console.log(e);
                      }

                      Examples of correct code for this rule:

                      /*eslint global-require: "error"*/
                      
                      // all these variations of require() are ok
                      require('x');
                      var y = require('y');
                      var z;
                      z = require('z').initialize();
                      
                      // requiring a module and using it in a function is ok
                      var fs = require('fs');
                      function readFile(filename, callback) {
                          fs.readFile(filename, callback)
                      }
                      
                      // you can use a ternary to determine which module to require
                      var logger = DEBUG ? require('dev-logger') : require('logger');
                      
                      // if you want you can require() at the end of your module
                      function doSomethingA() {}
                      function doSomethingB() {}
                      var x = require("x"),
                          z = require("z");

                      When Not To Use It

                      If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

                      Unexpected require().
                      Open

                          sharp = require('sharp');
                      Severity: Minor
                      Found in utils.js by eslint

                      Enforce require() on the top-level module scope (global-require)

                      In Node.js, module dependencies are included using the require() function, such as:

                      var fs = require("fs");

                      While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

                      function foo() {
                      
                          if (condition) {
                              var fs = require("fs");
                          }
                      }

                      Since require() does a synchronous load, it can cause performance problems when used in other locations.

                      Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

                      Rule Details

                      This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

                      Examples of incorrect code for this rule:

                      /*eslint global-require: "error"*/
                      /*eslint-env es6*/
                      
                      // calling require() inside of a function is not allowed
                      function readFile(filename, callback) {
                          var fs = require('fs');
                          fs.readFile(filename, callback)
                      }
                      
                      // conditional requires like this are also not allowed
                      if (DEBUG) { require('debug'); }
                      
                      // a require() in a switch statement is also flagged
                      switch(x) { case '1': require('1'); break; }
                      
                      // you may not require() inside an arrow function body
                      var getModule = (name) => require(name);
                      
                      // you may not require() inside of a function body as well
                      function getModule(name) { return require(name); }
                      
                      // you may not require() inside of a try/catch block
                      try {
                          require(unsafeModule);
                      } catch(e) {
                          console.log(e);
                      }

                      Examples of correct code for this rule:

                      /*eslint global-require: "error"*/
                      
                      // all these variations of require() are ok
                      require('x');
                      var y = require('y');
                      var z;
                      z = require('z').initialize();
                      
                      // requiring a module and using it in a function is ok
                      var fs = require('fs');
                      function readFile(filename, callback) {
                          fs.readFile(filename, callback)
                      }
                      
                      // you can use a ternary to determine which module to require
                      var logger = DEBUG ? require('dev-logger') : require('logger');
                      
                      // if you want you can require() at the end of your module
                      function doSomethingA() {}
                      function doSomethingB() {}
                      var x = require("x"),
                          z = require("z");

                      When Not To Use It

                      If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

                      There are no issues that match your filters.

                      Category
                      Status