Ember-Swiper/ember-cli-swiper

View on GitHub

Showing 3 of 3 total issues

Function _getOptions has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  _getOptions() {
    let attrs = getProperties(this, ...keys(this.attrs)); // eslint-disable-line ember/no-attrs-in-components
    let options = assign({}, this.get('options'), attrs);

    // Overwrite pagination element selector
Severity: Minor
Found in addon/components/swiper-container.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _getOptions has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _getOptions() {
    let attrs = getProperties(this, ...keys(this.attrs)); // eslint-disable-line ember/no-attrs-in-components
    let options = assign({}, this.get('options'), attrs);

    // Overwrite pagination element selector
Severity: Major
Found in addon/components/swiper-container.js - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

        if (options.pagination) {
          let customPaginationEl
            = (typeof options.pagination === 'string' && options.pagination) // custom string selector
            || (typeof options.pagination === 'object' && options.pagination.el) // custom `el` option selector
            || '';
    Severity: Major
    Found in addon/components/swiper-container.js - About 40 mins to fix
      Severity
      Category
      Status
      Source
      Language