Showing 135 of 169 total issues
Method getItems
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getItems()
{
$query = $this->dataProviderHelper->getQuery();
$category = $this->dataProviderHelper->getCategory();
$promises = [];
Method match
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function match(MagentoHttpRequest $request)
{
if ($this->skip($request)) {
return false;
}
Method __construct
has 12 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
View\Element\Template\Context $context,
View\LayoutFactory $layoutFactory,
View\Layout\ReaderPool $layoutReaderPool,
Framework\Translate\InlineInterface $translateInline,
View\Layout\BuilderFactory $layoutBuilderFactory,
Method initFilters
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
protected function initFilters(Layer $layer)
{
$request = $this->context->getRequest();
if (!$request->hasParameter('tn_cid')) {
$request->addCategoryFilter($layer->getCurrentCategory());
Method handleRequestSuccess
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function handleRequestSuccess(
ResponseInterface $httpResponse,
HttpRequest $httpRequest,
Request $tweakwiseRequest,
): Response {
Method execute
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function execute()
{
$json = $this->resultFactory->create('json');
$facetRequest = $this->requestFactory->create();
Method apply
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function apply()
{
$eavSetup = $this->eavSetupFactory->create(['setup' => $this->moduleDataSetup]);
$eavSetup->addAttribute(
Method forProduct
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function forProduct(Product $product, $type)
{
$attribute = $this->getAttribute($type);
$templateId = (int) $product->getData($attribute);
Function getSearchBanners
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
private function getSearchBanners()
{
$navigationContext = $this->getData('tweakwise_navigation_context')->getNavigationContext()->getContext();
$result = [];
$banners = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function prepareFieldsMeta
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
private function prepareFieldsMeta($fieldsMap, $fieldsMeta)
{
$canEditDesign = $this->auth->isAllowed('Magento_Catalog::edit_category_design');
$result = [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method install
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function install(SchemaSetupInterface $setup, ModuleContextInterface $context)
{
$installer = $setup;
$installer->startSetup();
Method getOriginalUrl
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getOriginalUrl(MagentoHttpRequest $request): string
{
$twOriginalUrl = $request->getParam('__tw_original_url');
if ($twOriginalUrl) {
// This seems ugly, perhaps there is another way?
Method __construct
has 11 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
UrlModel $magentoUrl,
UrlFactory $urlFactory,
Resolver $layerResolver,
FilterSlugManager $filterSlugManager,
QueryParameterStrategy $queryParameterStrategy,
Method getUrl
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getUrl(): string
{
$isSearch = false;
try {
$url = $this->getCategoryUrl();
Method aroundRender
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function aroundRender(FilterRenderer $subject, Closure $proceed, FilterInterface $filter)
{
if (!$filter instanceof Filter) {
return $proceed($filter);
}
Method getSwatchData
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getSwatchData(Filter $filter): array
{
// Get a map of filter item labels keyed by label
$labels = array_flip(
array_map(
Method getCurrentQueryUrl
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
protected function getCurrentQueryUrl(MagentoHttpRequest $request, array $query)
{
$selectedFilters = $request->getQuery();
$reservedParams = [
self::PARAM_LIMIT,
Method getCategoryFilterSelectUrl
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function getCategoryFilterSelectUrl(MagentoHttpRequest $request, Item $item): string
{
$category = $this->strategyHelper->getCategoryFromItem($item);
if (!$this->getSearch($request)) {
$categoryUrl = $category->getUrl();
Method execute
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function execute(Observer $observer)
{
if (!$this->config->isSearchEnabled()) {
return;
}
Method __construct
has 10 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
UrlInterface $url,
Registry $registry,
Config $config,
StoreManagerInterface $storeManager,
CategoryRepositoryInterface $categoryRepository,