Sign upLogin

EmicoEcommerce/Magento2Tweakwise

View on GitHub
Star

Showing 135 of 169 total issues

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        UrlStrategyFactory $urlStrategyFactory,
        MagentoHttpRequest $request,
        CategoryRepositoryInterface $categoryRepository,
        ExportHelper $exportHelper,
        UrlModel $magentoUrl
Severity: Minor
Found in Model/Catalog/Layer/Url.php - About 35 mins to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            Config $config,
        LocaleFormat $localeFormat,
        Registry $registry,
        Context $context,
        array $data = []
    Severity: Minor
    Found in Block/Autocomplete/FormMini.php - About 35 mins to fix

      Function save has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function save(AttributeSlugInterface $attributeSlug): AttributeSlugInterface
    {
        try {
            //check for existing slugs with the same slug
            try {
      Severity: Minor
      Found in Model/AttributeSlugRepository.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function execute(Observer $observer)
    {
        $block = $observer->getData('block');
        if (!$block instanceof Navigation) {
            return;
      Severity: Minor
      Found in Model/Observer/NavigationHtmlOverride.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function extractFilterValuesWhitelist has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function extractFilterValuesWhitelist(?string $filterList = null): array
    {
        if (empty($filterList)) {
            return [];
        }
      Severity: Minor
      Found in Model/ConfigAttributeProcessService.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addCategoryFilter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function addCategoryFilter($category)
    {
        $ids = [];
        if (is_numeric($category)) {
            $ids[] = $category;
      Severity: Minor
      Found in Model/Client/Request.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getUrl(): string
    {
        $isSearch = false;
        try {
            $url = $this->getCategoryUrl();
      Severity: Minor
      Found in Model/Client/Type/SuggestionType/SuggestionTypeFacet.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getAttributeSelectUrl has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getAttributeSelectUrl(MagentoHttpRequest $request, Item $item): string
    {
        $settings = $item
            ->getFilter()
            ->getFacet()
      Severity: Minor
      Found in Model/Catalog/Layer/Url/Strategy/QueryParameterStrategy.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function aroundLoadVariationByFallback has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function aroundLoadVariationByFallback(
        Data $subject,
        callable $proceed,
        Product $parentProduct,
        array $attributes
      Severity: Minor
      Found in Model/Swatches/Plugin.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function execute(Observer $observer)
    {
        foreach ($observer->getEvent()->getAttribute()->getOptions() as $option) {
            try {
                if (empty($option->getLabel()) || ctype_space((string) $option->getLabel())) {
      Severity: Minor
      Found in Observer/RemoveTweakwiseSlugsBeforeSaveAttribute.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in Model/Catalog/Layer/Url/UrlModel.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $this->originalProvider->getCollection($category);
          Severity: Major
          Found in Model/Catalog/Layer/ItemCollectionProvider.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $proceed($attributeCode, $optionId);
            Severity: Major
            Found in Block/LayeredNavigation/RenderLayered/Plugin.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return $block->toHtml();
              Severity: Major
              Found in Block/Navigation/FilterRenderer/Plugin.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return $templateId;
                Severity: Major
                Found in Model/Config/TemplateFinder.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return $defaultTemplateId;
                  Severity: Major
                  Found in Model/Config/TemplateFinder.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return $proceed($layer);
                    Severity: Major
                    Found in Model/Catalog/Layer/FilterList/Plugin.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return;
                      Severity: Major
                      Found in Model/Observer/CatalogSearchRedirect.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return;
                        Severity: Major
                        Found in Model/Observer/CatalogSearchRedirect.php - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language