EmicoEcommerce/Magento2Tweakwise

View on GitHub

Showing 135 of 169 total issues

Avoid too many return statements within this method.
Open

            return;
Severity: Major
Found in Model/Config.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return $this->config->getRecommendationsGroupCode($type);
    Severity: Major
    Found in Model/Config/TemplateFinder.php - About 30 mins to fix

      Function aroundGetLastAddedProduct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function aroundGetLastAddedProduct(Crosssell $crossell, Closure $proceed)
          {
              if ($this->lastAddedProduct === null) {
                  $product = null;
                  $productId = $this->_getLastAddedProductId();
      Severity: Minor
      Found in Block/Checkout/Cart/Crosssell/Plugin.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function skip has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function skip(MagentoHttpRequest $request): bool
          {
              $requestPath = $request->getPathInfo();
              foreach ($this->skipMatchExtensions as $fileExtension) {
                  // Check for string length of the request path.
      Severity: Minor
      Found in Model/Catalog/Layer/Url/Strategy/PathSlugStrategy.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setAttributes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setAttributes(array $attributes)
          {
              $attributes = $this->normalizeArray($attributes, 'attributes');
      
              $values = [];
      Severity: Minor
      Found in Model/Client/Response/FacetAttributesResponse.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function execute()
          {
              $result = [];
              $json = $this->resultFactory->create('json');
              $facetRequest = $this->requestFactory->create();
      Severity: Minor
      Found in Controller/Ajax/Facets.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getStoreConfig has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getStoreConfig(string $path, Store $store = null)
          {
              if ($store) {
                  return $store->getConfig($path);
              }
      Severity: Minor
      Found in Model/Config.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validateHash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function validateHash($request)
          {
              $isValid = false;
              $hash = $request->getParam('__tw_hash', null);
      
      
      Severity: Minor
      Found in Model/FilterFormInputProvider/HashInputProvider.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setFacets has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setFacets(array $facets)
          {
              $facets = $this->normalizeArray($facets, 'facet');
      
              $values = [];
      Severity: Minor
      Found in Model/Client/Response/FacetResponse.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getResponse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getResponse(): ProductNavigationResponse|null
          {
              if (!$this->response) {
                  $request = $this->getRequest();
      
      
      Severity: Minor
      Found in Model/Catalog/Layer/NavigationContext.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getCategoryFilterSelectUrl has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getCategoryFilterSelectUrl(MagentoHttpRequest $request, Item $item): string
          {
              $category = $this->strategyHelper->getCategoryFromItem($item);
              if (!$this->getSearch($request)) {
                  $categoryUrl = $category->getUrl();
      Severity: Minor
      Found in Model/Catalog/Layer/Url/Strategy/QueryParameterStrategy.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function shouldPageBeIndexable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function shouldPageBeIndexable(): bool
          {
              foreach ($this->getActiveFilterItems() as $item) {
                  if ($item instanceof Item) {
                      if (!$this->shouldFilterBeIndexable($item)) {
      Severity: Minor
      Found in Model/Seo/FilterHelper.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function toArray has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function toArray(): array
          {
              $product = $this->product;
              $priceInfo = $product->getPriceInfo();
              $productType = $product->getTypeId();
      Severity: Minor
      Found in Model/Autocomplete/DataProvider/ProductItem.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function updateTemplate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function updateTemplate(CurrentContext $currentContext)
          {
              if ($this->config->getUseDefaultLinkRenderer()) {
                  return;
              }
      Severity: Minor
      Found in Block/LayeredNavigation/Navigation/State.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getRequestValues has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getRequestValues(MagentoHttpRequest $request, Item $item)
          {
              $filter = $item->getFilter();
              $settings = $filter
                  ->getFacet()
      Severity: Minor
      Found in Model/Catalog/Layer/Url/Strategy/QueryParameterStrategy.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language