Showing 132 of 165 total issues
Method __construct
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Template\Context $context,
Config $config,
NavigationConfig $navigationConfig,
FilterHelper $filterHelper,
Json $jsonSerializer,
Function aroundGetFilters
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function aroundGetFilters(FilterList $subject, Closure $proceed, Layer $layer)
{
if (!$this->config->isLayeredEnabled()) {
if (!$this->config->isSearchEnabled() || !($layer instanceof Layer\Search)) {
return $proceed($layer);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function apply
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function apply(
MagentoHttpRequest $request,
ProductNavigationRequest $navigationRequest
): FilterApplierInterface {
// Order / pagination etc. is still done with query parameters. Also apply this using the queryParameter strategy
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Context $context,
Config $config,
AjaxNavigationResult $ajaxNavigationResult,
HashInputProvider $hashInputProvider,
Timer $timer,
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
CategoryRepository $categoryRepository,
StoreManagerInterface $storeManager,
UrlInterface $url,
Helper $exportHelper,
Config $config,
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Config $config,
Registry $registry,
Context $context,
TemplateFinder $templateFinder,
Session $checkoutSession,
Function buildFilterSlugPath
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function buildFilterSlugPath(array $filters): string
{
if (empty($filters)) {
return '';
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getActiveItems
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function getActiveItems()
{
$result = [];
foreach ($this->getItems() as $item) {
if (!$item->isActive()) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function aroundGetAvailableOrders
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function aroundGetAvailableOrders(Toolbar $subject, Closure $proceed)
{
if (!$this->config->isLayeredEnabled()) {
if (!$this->config->isSearchEnabled() || !($this->context->getRequest() instanceof ProductSearchRequest)) {
return $proceed();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Context $context,
Resolver $layerResolver,
Config $config,
Url $url,
CurrentContext $currentContext,
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
ScopeConfigInterface $config,
Json $jsonSerializer,
RequestInterface $request,
State $state,
WriterInterface $configWriter,
Function getSwatchData
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function getSwatchData(Filter $filter): array
{
// Get a map of filter item labels keyed by label
$labels = array_flip(
array_map(
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
!function(a){function f(a,b){if(!(a.originalEvent.touches.length>1)){a.preventDefault();var c=a.originalEvent.changedTouches[0],d=document.createEvent("MouseEvents");d.initMouseEvent(b,!0,!0,window,1,c.screenX,c.screenY,c.clientX,c.clientY,!1,!1,!1,!1,0,null),a.target.dispatchEvent(d)}}if(a.support.touch="ontouchend"in document,a.support.touch){var e,b=a.ui.mouse.prototype,c=b._mouseInit,d=b._mouseDestroy;b._touchStart=function(a){var b=this;!e&&b._mouseCapture(a.originalEvent.changedTouches[0])&&(e=!0,b._touchMoved=!1,f(a,"mouseover"),f(a,"mousemove"),f(a,"mousedown"))},b._touchMove=function(a){e&&(this._touchMoved=!0,f(a,"mousemove"))},b._touchEnd=function(a){e&&(f(a,"mouseup"),f(a,"mouseout"),this._touchMoved||f(a,"click"),e=!1)},b._mouseInit=function(){var b=this;b.element.bind({touchstart:a.proxy(b,"_touchStart"),touchmove:a.proxy(b,"_touchMove"),touchend:a.proxy(b,"_touchEnd")}),c.call(b)},b._mouseDestroy=function(){var b=this;b.element.unbind({touchstart:a.proxy(b,"_touchStart"),touchmove:a.proxy(b,"_touchMove"),touchend:a.proxy(b,"_touchEnd")}),d.call(b)}}}(jQuery);
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Config $config,
LocaleFormat $localeFormat,
Registry $registry,
Context $context,
array $data = []
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
TranslitUrl $translitUrl,
AttributeSlugRepositoryInterface $attributeSlugRepository,
AttributeSlugInterfaceFactory $attributeSlugFactory,
CacheInterface $cache,
SerializerInterface $serializer
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
UrlStrategyFactory $urlStrategyFactory,
MagentoHttpRequest $request,
CategoryRepositoryInterface $categoryRepository,
ExportHelper $exportHelper,
UrlModel $magentoUrl
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Layer $layer,
FacetType $facet,
ItemFactory $itemFactory,
StoreManager $storeManager,
Attribute $attribute = null
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Config $config,
Logger $log,
ItemCollectionProviderInterface $originalProvider,
CollectionFactory $collectionFactory,
NavigationContext $navigationContext
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Config $config,
Logger $log,
ResponseFactory $responseFactory,
EndpointManager $endpointManager,
Timer $timer
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
AttributeSlugResource $resource,
AttributeSlugInterfaceFactory $entityFactory,
CollectionFactory $collectionFactory,
AttributeSlugSearchResultsInterfaceFactory $searchResultsFactory,
CollectionProcessorInterface $collectionProcessor