EmicoEcommerce/Magento2TweakwiseExport

View on GitHub

Showing 83 of 111 total issues

Function createSimpleProduct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function createSimpleProduct(array $data, array $configurableAttributes): ProductInterface
    {
        // Rewrite configurable data to option values
        foreach ($configurableAttributes as $attributeCode) {
            if (!isset($data[$attributeCode])) {
Severity: Minor
Found in TestHelper/Data/Product/ConfigurableProvider.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ensureIdsAndSkus has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function ensureIdsAndSkus(): void
    {
        $ids = [];
        $skus = [];
        foreach ($this as $entity) {
Severity: Minor
Found in Model/Write/Products/Collection.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getStockItemMap has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getStockItemMap(Collection|StockCollection $collection): array
    {
        if ($collection->count() === 0) {
            return [];
        }

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language