Enterprise-CMCS/macpro-appian-connector

View on GitHub
src/libs/topics-lib.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function createTopics has 65 lines of code (exceeds 40 allowed). Consider refactoring.
Open

export async function createTopics(brokerString, topicsConfig) {
  const topics = topicsConfig;
  const brokers = brokerString.split(",");

  const kafka = new Kafka({
Severity: Major
Found in src/libs/topics-lib.js - About 2 hrs to fix

    Function create has 54 lines of code (exceeds 40 allowed). Consider refactoring.
    Open

      const create = async () => {
        await admin.connect();
    
        //fetch topics from MSK and filter out __ internal management topic
        const existingTopicList = _.filter(await admin.listTopics(), function (n) {
    Severity: Major
    Found in src/libs/topics-lib.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const paritionConfig = _.map(topicsToUpdate, function (topic) {
            return {
              topic: _.get(topic, "topic"),
              count: _.get(topic, "numPartitions"),
            };
      Severity: Major
      Found in src/libs/topics-lib.js and 1 other location - About 1 hr to fix
      src/libs/topics-lib.js on lines 61..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const configOptions = _.map(topicsMetadata, function (topic) {
            return {
              name: _.get(topic, "name"),
              type: _.get(ResourceTypes, "TOPIC"),
            };
      Severity: Major
      Found in src/libs/topics-lib.js and 1 other location - About 1 hr to fix
      src/libs/topics-lib.js on lines 53..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status