Sign upLogin

ErikGartner/hyperdock

View on GitHub
Star

Showing 10 of 16 total issues

File experiment.py has 279 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import logging
from datetime import datetime
import os
import sys
import json
Severity: Minor
Found in hyperdock/common/experiment.py - About 2 hrs to fix

    Function test_start has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def test_start(self):
        """
        test experiment.start()
        essentially start() calls many other private methods making this
        unit test almost an integration test.
    Severity: Minor
    Found in tests/common/test_experiment.py - About 1 hr to fix

      Function _expand_spec has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def _expand_spec(spec, **kwargs):
        """
        Expands a single parameter specification.
        """
        fixed_params = {}
      Severity: Minor
      Found in hyperdock/supervisor/search/search.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function config has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def config(path="config.yml", force_reload=False):
    """
    Read the config for this module.
    Priority is env, config.yml then defaults.
    """
      Severity: Minor
      Found in hyperdock/common/config.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function retry has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def retry(func, nbr_retries, sleep_time, errors, *args, **kwargs):
      Severity: Minor
      Found in hyperdock/common/stability.py - About 45 mins to fix

        Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def __init__(
        Severity: Minor
        Found in hyperdock/worker/worker.py - About 35 mins to fix

          Function add_job has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def add_job(self, parameters, data, trial_id, trial_name, priority=0):
          Severity: Minor
          Found in hyperdock/common/workqueue.py - About 35 mins to fix

            Function launch_worker has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def launch_worker(mongodb, env, parallelism, loglevel, privileged):
            Severity: Minor
            Found in hyperdock/worker/main.py - About 35 mins to fix

              Function _monitor_experiments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def _monitor_experiments(self):
        """
        Monitor the status of the current experiments.
        Also checks to see if an experiment has been cancelled by the user.
        """
              Severity: Minor
              Found in hyperdock/worker/worker.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _kill_orphans has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def _kill_orphans(self):
        """
        Looks for orphaned jobs on the machine and if found kills them.
        """
        try:
              Severity: Minor
              Found in hyperdock/worker/worker.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language