Showing 10 of 985 total issues
File ConsultationService.php
has 430 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
<?php
namespace EscolaLms\Consultations\Services;
use Auth;
ConsultationService
has 34 functions (exceeds 20 allowed). Consider refactoring. Open
Open
class ConsultationService implements ConsultationServiceContract
{
private ConsultationRepositoryContract $consultationRepositoryContract;
private ConsultationUserRepositoryContract $consultationUserRepositoryContract;
private JitsiServiceContract $jitsiServiceContract;
Method generateJitsi
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function generateJitsi(int $consultationTermId): array
{
$consultationTerm = $this->consultationUserRepositoryContract->find($consultationTermId);
if (!$this->canGenerateJitsi(
$consultationTerm->executed_at,
Method forCurrentUserResponse
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function forCurrentUserResponse(
ListConsultationsRequest $listConsultationsRequest
): AnonymousResourceCollection {
$search = $listConsultationsRequest->except(['limit', 'skip', 'order', 'order_by', 'paginate']);
$consultations = $this->getConsultationsListForCurrentUser($search);
Method prepareFilters
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function prepareFilters(array $search)
{
$dto = new self($search);
$user = auth()->user();
Method generateJitsiUrlForEmail
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function generateJitsiUrlForEmail(int $consultationTermId, int $userId): ?string
{
$consultationTerm = $this->consultationUserRepositoryContract->find($consultationTermId);
$isModerator = false;
$configOverwrite = [];
Method run
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function run()
{
// create permissions
$admin = Role::findOrCreate(UserRole::ADMIN, 'api');
$tutor = Role::findOrCreate(UserRole::TUTOR, 'api');
Function prepareFilters
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
public static function prepareFilters(array $search)
{
$dto = new self($search);
$user = auth()->user();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method toArray
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function toArray($request)
{
$consultationServiceContract = app(ConsultationServiceContract::class);
$fields = [
'consultation_term_id' => $this->getKey(),
Function prepareFilters
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
public static function prepareFilters(array $search): self
{
$dto = new self($search);
$dto->addToCriteria(new NotNullCriterion($dto->model()->getTable() . '.executed_at'));
if ($dto->getStatus()) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"