Sign upLogin

EscolaLMS/Consultations

View on GitHub
Star

Showing 10 of 985 total issues

File ConsultationService.php has 430 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace EscolaLms\Consultations\Services;

use Auth;
Severity: Minor
Found in src/Services/ConsultationService.php - About 6 hrs to fix

    ConsultationService has 34 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ConsultationService implements ConsultationServiceContract
{
    private ConsultationRepositoryContract $consultationRepositoryContract;
    private ConsultationUserRepositoryContract $consultationUserRepositoryContract;
    private JitsiServiceContract $jitsiServiceContract;
    Severity: Minor
    Found in src/Services/ConsultationService.php - About 4 hrs to fix

      Method generateJitsi has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function generateJitsi(int $consultationTermId): array
    {
        $consultationTerm = $this->consultationUserRepositoryContract->find($consultationTermId);
        if (!$this->canGenerateJitsi(
            $consultationTerm->executed_at,
      Severity: Minor
      Found in src/Services/ConsultationService.php - About 1 hr to fix

        Method forCurrentUserResponse has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function forCurrentUserResponse(
        ListConsultationsRequest $listConsultationsRequest
    ): AnonymousResourceCollection {
        $search = $listConsultationsRequest->except(['limit', 'skip', 'order', 'order_by', 'paginate']);
        $consultations = $this->getConsultationsListForCurrentUser($search);
        Severity: Minor
        Found in src/Services/ConsultationService.php - About 1 hr to fix

          Method prepareFilters has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
          Severity: Minor
          Found in src/Dto/FilterListDto.php - About 1 hr to fix

            Method generateJitsiUrlForEmail has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function generateJitsiUrlForEmail(int $consultationTermId, int $userId): ?string
    {
        $consultationTerm = $this->consultationUserRepositoryContract->find($consultationTermId);
        $isModerator = false;
        $configOverwrite = [];
            Severity: Minor
            Found in src/Services/ConsultationService.php - About 1 hr to fix

              Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function run()
    {
        // create permissions
        $admin = Role::findOrCreate(UserRole::ADMIN, 'api');
        $tutor = Role::findOrCreate(UserRole::TUTOR, 'api');
              Severity: Minor
              Found in database/seeders/ConsultationsPermissionSeeder.php - About 1 hr to fix

                Function prepareFilters has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public static function prepareFilters(array $search)
    {
        $dto = new self($search);
        $user = auth()->user();
                Severity: Minor
                Found in src/Dto/FilterListDto.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method toArray has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function toArray($request)
    {
        $consultationServiceContract = app(ConsultationServiceContract::class);
        $fields = [
            'consultation_term_id' => $this->getKey(),
                Severity: Minor
                Found in src/Http/Resources/ConsultationTermsResource.php - About 1 hr to fix

                  Function prepareFilters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function prepareFilters(array $search): self
    {
        $dto = new self($search);
        $dto->addToCriteria(new NotNullCriterion($dto->model()->getTable() . '.executed_at'));
        if ($dto->getStatus()) {
                  Severity: Minor
                  Found in src/Dto/FilterConsultationTermsListDto.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language