Sign upLogin

EscolaLMS/Images

View on GitHub
Star

Showing 7 of 13 total issues

File ImagesTest.php has 342 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Api;

use EscolaLms\Images\Events\FileStored;
Severity: Minor
Found in tests/Api/ImagesTest.php - About 4 hrs to fix

    Method testAdministrableConfigApi has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function testAdministrableConfigApi(): void
    {
        $configKey = SettingsServiceProvider::CONFIG_KEY;
        $user = $this->makeAdmin();
    Severity: Major
    Found in tests/Api/SettingsTest.php - About 3 hrs to fix

      Method test_image_post_results has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function test_image_post_results(): void
    {
        $filename = 'test.jpg';
        $filepath = realpath(__DIR__ . '/' . $filename);
      Severity: Minor
      Found in tests/Api/ImagesTest.php - About 1 hr to fix

        Method test_invalid_image_post_results has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function test_invalid_image_post_results(): void
    {
        Event::fake([FileStored::class]);
        $disk = Storage::disk('local');
        Severity: Minor
        Found in tests/Api/ImagesTest.php - About 1 hr to fix

          Method render has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function render(string $path, $params): array
    {
        $hash = sha1($path . json_encode($params));
        $ext = pathinfo($path)['extension'] ?? null;
          Severity: Minor
          Found in src/Services/ImagesService.php - About 1 hr to fix

            Function render has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function render(string $path, $params): array
    {
        $hash = sha1($path . json_encode($params));
        $ext = pathinfo($path)['extension'] ?? null;
            Severity: Minor
            Found in src/Services/ImagesService.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function determineWidthAndHeight has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function determineWidthAndHeight(InterventionImage $img, array $params): array
    {
        if (isset($params['size'])) {
            $size_definitions = config('images.public.size_definitions');
            if (is_array($size_definitions) && array_key_exists($params['size'], $size_definitions)) {
            Severity: Minor
            Found in src/Services/ImagesService.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language