Sign upLogin

EscolaLMS/payments

View on GitHub
Star

Showing 6 of 10 total issues

PaymentProcessor has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class PaymentProcessor
{
    private Payment $payment;

    public function __construct(Payment $payment)
Severity: Minor
Found in src/Entities/PaymentProcessor.php - About 3 hrs to fix

    Function purchase has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function purchase(array $parameters = []): self
    {
        $driver = $parameters['gateway'] ?? null;

        if (!is_null($driver) && Payments::isDriverEnabled($driver)) {
    Severity: Minor
    Found in src/Entities/PaymentProcessor.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method purchase has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function purchase(array $parameters = []): self
    {
        $driver = $parameters['gateway'] ?? null;

        if (!is_null($driver) && Payments::isDriverEnabled($driver)) {
    Severity: Minor
    Found in src/Entities/PaymentProcessor.php - About 1 hr to fix

      Function callback has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function callback(Request $request): self
    {
        $callbackResponse = $this->getPaymentDriver()->callback($request);

        $this->clearRedirect();
      Severity: Minor
      Found in src/Entities/PaymentProcessor.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct(bool $success = true, ?int $order_id = null, ?string $request_id = null, ?string $refunds_uuid = null, ?string $error = null)
      Severity: Minor
      Found in src/Gateway/Responses/CallbackRefundResponse.php - About 35 mins to fix

        Function instantiateFromRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function instantiateFromRequest(Request $request): self
    {
        $criteria = new Collection();

        if ($request->has('status')) {
        Severity: Minor
        Found in src/Dtos/PaymentFilterCriteriaDto.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language