Esri/react-arcgis

View on GitHub

Showing 5 of 15 total issues

Function render has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public render() {
        const centerStyle = {
            left: '50%',
            marginRight: '-50%',
            position: 'absolute',
Severity: Major
Found in src/ts/components/ArcBase.tsx - About 2 hrs to fix

    Function WebBase has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          ([WebConstructor, ViewConstructor, all], containerId) => {
            const mapData = new Promise((resolve, reject) => {
                try {
                    const map: __esri.WebMap | __esri.WebScene = new WebConstructor({
                        portalItem: {
    Severity: Minor
    Found in src/ts/components/ArcComposites.tsx - About 1 hr to fix

      Function mapData has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              const mapData = new Promise((resolve, reject) => {
                  try {
                      const map: __esri.WebMap | __esri.WebScene = new WebConstructor({
                          portalItem: {
                              id: props.id
      Severity: Minor
      Found in src/ts/components/ArcComposites.tsx - About 1 hr to fix

        Function BermudaTriangle has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const BermudaTriangle = (props) => {
        
            const [graphic, setGraphic] = useState(null);
            useEffect(() => {
        
        
        Severity: Minor
        Found in demo/src/BermudaTriangle.js - About 1 hr to fix

          Function render has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public render() {
                  const centerStyle = {
                      left: '50%',
                      marginRight: '-50%',
                      position: 'absolute',
          Severity: Minor
          Found in src/ts/components/ArcBase.tsx - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language