EvilFreelancer/openvpn-php

View on GitHub

Showing 7 of 7 total issues

Config has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class Config implements ConfigInterface, GeneratorInterface
{
    /**
     * List of types of certs, for validation
     */
Severity: Minor
Found in src/Config.php - About 3 hrs to fix

    Function generateArray has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        private function generateArray(): array
        {
            // Init the variable
            $config = [];
    
    
    Severity: Minor
    Found in src/Generator.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generateArray has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function generateArray(): array
        {
            // Init the variable
            $config = [];
    
    
    Severity: Minor
    Found in src/Generator.php - About 1 hr to fix

      Function set has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function set(string $name, $value = null): ConfigInterface
          {
              $name = mb_strtolower($name);
      
              // Check if key is certificate or push, or classic parameter
      Severity: Minor
      Found in src/Config.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function load has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function load($content, string $type = 'raw'): array
          {
              $result = ['total' => 0, 'read' => 0];
              $lines  = [];
      
      
      Severity: Minor
      Found in src/Import.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $this;
      Severity: Major
      Found in src/Config.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this;
        Severity: Major
        Found in src/Config.php - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language