Sign upLogin

FOGProject/fog-too

View on GitHub
Star
api/services/AssociationService.js

Summary

Maintainability
C
1 day
Test Coverage

Function manyAssociationWrapper has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var manyAssociationWrapper = function(parent, child, viaAttribute, parentId, childIds, add, next) {
  next = (typeof next !== 'function') ? function() {} : next;
  var validationErr = validateWrapperParameters(parent, child, viaAttribute, parentId);
  if(validationErr) return next(validationErr);
  var pModel;
Severity: Minor
Found in api/services/AssociationService.js - About 1 hr to fix

    Function singleAssociationWrapper has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var singleAssociationWrapper = function(parent, child, viaAttribute, parentId, childId, next) {
  next = (typeof next !== 'function') ? function() {} : next;
  var validationErr = validateWrapperParameters(parent, child, viaAttribute, parentId);
  if(validationErr) return next(validationErr);
  if(!parent.definition.hasOwnProperty(viaAttribute)) return next('Invalid via attribute');
    Severity: Minor
    Found in api/services/AssociationService.js - About 1 hr to fix

      Function manyAssociationWrapper has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      var manyAssociationWrapper = function(parent, child, viaAttribute, parentId, childIds, add, next) {
      Severity: Major
      Found in api/services/AssociationService.js - About 50 mins to fix

        Function unassignMany has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          unassignMany: function(parent, child, viaAttribute, parentId, childIds, next) {
        Severity: Minor
        Found in api/services/AssociationService.js - About 45 mins to fix

          Function setSingle has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            setSingle: function(parent, child, viaAttribute, parentId, childId, next) {
          Severity: Minor
          Found in api/services/AssociationService.js - About 45 mins to fix

            Function assignMany has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              assignMany: function(parent, child, viaAttribute, parentId, childIds, next) {
            Severity: Minor
            Found in api/services/AssociationService.js - About 45 mins to fix

              Function singleAssociationWrapper has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              var singleAssociationWrapper = function(parent, child, viaAttribute, parentId, childId, next) {
              Severity: Minor
              Found in api/services/AssociationService.js - About 45 mins to fix

                Avoid too many return statements within this function.
                Open

                  return;
                Severity: Major
                Found in api/services/AssociationService.js - About 30 mins to fix

                  Function validateWrapperParameters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  var validateWrapperParameters = function (parent, child, viaAttribute, parentId) {
  if(typeof parent !== 'object' || typeof parent.identity !== 'string' || parent.identity.length === 0 
          || typeof parent.findOne !== 'function')
    return 'Parent parameter is not a model';
  if(typeof child !== 'object' || typeof child.identity !== 'string' || child.identity.length === 0
                  Severity: Minor
                  Found in api/services/AssociationService.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        parent.findOne({id: parentId}).exec(function(err, pResult) {
        if(err) return cb(err);
        if(!pResult) return cb('Invalid parent id');
        cb();
      });
                  Severity: Major
                  Found in api/services/AssociationService.js and 1 other location - About 1 hr to fix
                  api/services/AssociationService.js on lines 89..93

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        child.findOne({id: childId}).exec(function(err, cResult) {
        if(err) return cb(err);
        if(!cResult) return cb('Invalid child id');
        cb();
      });
                  Severity: Major
                  Found in api/services/AssociationService.js and 1 other location - About 1 hr to fix
                  api/services/AssociationService.js on lines 78..82

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if(typeof parent !== 'object' || typeof parent.identity !== 'string' || parent.identity.length === 0 
          || typeof parent.findOne !== 'function')
    return 'Parent parameter is not a model';
                  Severity: Major
                  Found in api/services/AssociationService.js and 1 other location - About 1 hr to fix
                  api/services/AssociationService.js on lines 14..16

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 57.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if(typeof child !== 'object' || typeof child.identity !== 'string' || child.identity.length === 0 
          || typeof child.findOne !== 'function')
    return 'Child parameter is not a model';
                  Severity: Major
                  Found in api/services/AssociationService.js and 1 other location - About 1 hr to fix
                  api/services/AssociationService.js on lines 11..13

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 57.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status