FabrizioBrancati/SwiftyBot

View on GitHub

Showing 3 of 18 total issues

Function create has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

    mutating func create(for request: Request) throws -> Future<Response> { // swiftlint:disable:this cyclomatic_complexity function_body_length
        /// Decode the request.
        let pageResponse = try request.content.syncDecode(PageRequest.self)
        /// Check that the request comes from a "page".
        guard pageResponse.object == "page" else {
Severity: Minor
Found in Sources/Messenger/Response/Response.swift - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function create has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    mutating func create(for request: Request) throws -> Future<Response> { // swiftlint:disable:this cyclomatic_complexity function_body_length
        /// Decode the request.
        let pageResponse = try request.content.syncDecode(PageRequest.self)
        /// Check that the request comes from a "page".
        guard pageResponse.object == "page" else {
Severity: Major
Found in Sources/Messenger/Response/Response.swift - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                            switch payload {
                            /// It's a Get Started payload.
                            case GetStarted.defaultPayload:
                                /// Set the response message.
                                message = .text("""
    Severity: Major
    Found in Sources/Messenger/Response/Response.swift - About 45 mins to fix
      Severity
      Category
      Status
      Source
      Language