Sign upLogin

Fannon/mobo

View on GitHub
Star
lib/modelToText/generateGraph.js

Summary

Maintainability
F
4 days
Test Coverage

Function analyzeModels has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

exports.analyzeModels = function(models, fields) {
    'use strict';

    var model;
    var modelPageName;
Severity: Minor
Found in lib/modelToText/generateGraph.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function analyzeForms has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

exports.analyzeForms = function(forms) {
    'use strict';

    for (var formName in forms) {
Severity: Minor
Found in lib/modelToText/generateGraph.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function analyzeModels has 83 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.analyzeModels = function(models, fields) {
    'use strict';

    var model;
    var modelPageName;
Severity: Major
Found in lib/modelToText/generateGraph.js - About 3 hrs to fix

    File generateGraph.js has 298 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    //////////////////////////////////////////
// Requirements                         //
//////////////////////////////////////////

var fs         = require('fs-extra');
    Severity: Minor
    Found in lib/modelToText/generateGraph.js - About 3 hrs to fix

      Function gefxExport has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.gefxExport = function(nodes, edges) {
    'use strict';

    var node;
    var edge;
      Severity: Minor
      Found in lib/modelToText/generateGraph.js - About 2 hrs to fix

        Function analyzeForms has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.analyzeForms = function(forms) {
    'use strict';

    for (var formName in forms) {
        Severity: Minor
        Found in lib/modelToText/generateGraph.js - About 1 hr to fix

          Function analyzeFields has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.analyzeFields = function(fields) {
    'use strict';

    for (var fieldName in fields) {
          Severity: Minor
          Found in lib/modelToText/generateGraph.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function analyzeFields has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports.analyzeFields = function(fields) {
    'use strict';

    for (var fieldName in fields) {
          Severity: Minor
          Found in lib/modelToText/generateGraph.js - About 1 hr to fix

            Function getColor has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            exports.getColor = function(type) {
    'use strict';
    if (type) {
        if (type === 'Form') {
            return 'r="73" g="199" b="232"';
            Severity: Minor
            Found in lib/modelToText/generateGraph.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                if (model.items) {
                        modelId = model.items.id;
                    }
            Severity: Major
            Found in lib/modelToText/generateGraph.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if (modelId) {
                        var edgeId = formPageName + '-' + modelName;

                        // Ignore wikitext attributes, since they are directly written into the form template
                        if (!exports.edges[edgeId] && !model.wikitext) {
              Severity: Major
              Found in lib/modelToText/generateGraph.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                } else if (exports.nodes[modelPageName]) {

                    edge = _.cloneDeep(edgeTemplate);

                    // Checks if first char is uppercase. If it is, it references to a Template
                Severity: Major
                Found in lib/modelToText/generateGraph.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      for (var i = 0; i < inspect.form.length; i++) {

                        edge = _.cloneDeep(edgeTemplate);

                        var target = inspect.form[i];
                  Severity: Major
                  Found in lib/modelToText/generateGraph.js - About 45 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return 'r="165" g="165" b="165"';
                    Severity: Major
                    Found in lib/modelToText/generateGraph.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return 'r="125" g="235" b="143"';
                      Severity: Major
                      Found in lib/modelToText/generateGraph.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return 'r="149" g="91" b="244"';
                        Severity: Major
                        Found in lib/modelToText/generateGraph.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return 'r="209" g="110" b="244"';
                          Severity: Major
                          Found in lib/modelToText/generateGraph.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                        return 'r="244" g="91" b="91"';
                            Severity: Major
                            Found in lib/modelToText/generateGraph.js - About 30 mins to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      exports.nodes[formPageName] = {
            id: formPageName,
            label: formPageName,
            niceLabel: form.title || formPageName,
            filepath: form.$filepath || '',
                              Severity: Major
                              Found in lib/modelToText/generateGraph.js and 1 other location - About 3 hrs to fix
                              lib/modelToText/generateGraph.js on lines 159..169

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 105.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      exports.nodes[modelPageName] = {
            id: modelPageName,
            label: modelPageName,
            niceLabel: model.title || modelPageName,
            filepath: model.$filepath || '',
                              Severity: Major
                              Found in lib/modelToText/generateGraph.js and 1 other location - About 3 hrs to fix
                              lib/modelToText/generateGraph.js on lines 289..299

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 105.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status