Sign upLogin

FarmBot/OpenFarm

View on GitHub
Star
app/assets/javascripts/guides/new.js

Summary

Maintainability
F
4 days
Test Coverage

Function newGuideCtrl has 313 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function newGuideCtrl(
    $scope,
    $http,
    $q,
    guideService,
Severity: Major
Found in app/assets/javascripts/guides/new.js - About 1 day to fix

    Function newGuideCtrl has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
    Open

      function newGuideCtrl(
    $scope,
    $http,
    $q,
    guideService,
    Severity: Minor
    Found in app/assets/javascripts/guides/new.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File new.js has 348 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    openFarmApp.config([
  '$locationProvider',
  function($locationProvider) {
    $locationProvider.html5Mode(false).hashPrefix('!');
  },
    Severity: Minor
    Found in app/assets/javascripts/guides/new.js - About 4 hrs to fix

      Function createStageData has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function createStageData(stage, guide) {
      var data = {};
      var stageActions = [];
      if (stage.selected) {
        if (stage.stage_action_options) {
      Severity: Major
      Found in app/assets/javascripts/guides/new.js - About 2 hrs to fix

        Function activate has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function activate() {
      // First FIRST we need to get all of the defaults
      $q.all([
        defaultService.processedDetailOptions(),
        cropService.getCropWithPromise(getUrlVar('crop_id')),
        Severity: Minor
        Found in app/assets/javascripts/guides/new.js - About 1 hr to fix

          Function buildParametersFromScope has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              var buildParametersFromScope = function() {
      // Gather things in the scope and put them in parameters.

      angular.forEach($scope.newGuide.time_span, function(val, key) {
        $scope.newGuide.time_span[key] = val || undefined;
          Severity: Minor
          Found in app/assets/javascripts/guides/new.js - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        environment:
              stage.environment
                .filter(function(s) {
                  return s.selected;
                })
            Severity: Major
            Found in app/assets/javascripts/guides/new.js and 2 other locations - About 1 hr to fix
            app/assets/javascripts/guides/new.js on lines 344..351
            app/assets/javascripts/guides/new.js on lines 352..359

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        light:
              stage.light
                .filter(function(s) {
                  return s.selected;
                })
            Severity: Major
            Found in app/assets/javascripts/guides/new.js and 2 other locations - About 1 hr to fix
            app/assets/javascripts/guides/new.js on lines 336..343
            app/assets/javascripts/guides/new.js on lines 344..351

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        soil:
              stage.soil
                .filter(function(s) {
                  return s.selected;
                })
            Severity: Major
            Found in app/assets/javascripts/guides/new.js and 2 other locations - About 1 hr to fix
            app/assets/javascripts/guides/new.js on lines 336..343
            app/assets/javascripts/guides/new.js on lines 352..359

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status