Finesse/QueryScribe

View on GitHub

Showing 30 of 44 total issues

Function processInsertFromSelect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function processInsertFromSelect(InsertFromSelect $row, $context): InsertFromSelect
    {
        if ($row->columns === null) {
            $columns = null;
        } else {
Severity: Minor
Found in src/PostProcessors/AbstractProcessor.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function joinArgumentsToJoinObject has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function joinArgumentsToJoinObject(string $type, $table, array $criterion = []): Join
    {
        if (is_array($table)) {
            $tableName = $table[0] ?? null;
            $tableAlias = $table[1] ?? null;
Severity: Minor
Found in src/QueryBricks/JoinTrait.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                    return new ValueCriterion($column, $rule, $value, $appendRule);
Severity: Major
Found in src/QueryBricks/WhereTrait.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return $this->handleException(new InvalidArgumentException('Too many arguments'));
    Severity: Major
    Found in src/QueryBricks/WhereTrait.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                              return $this->handleException(InvalidArgumentException::create('Argument $rule', $rule, ['string']));
      Severity: Major
      Found in src/QueryBricks/WhereTrait.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->handleException(InvalidArgumentException::create(
                            'The argument',
                            $argument,
                            ['Closure', 'array', StatementInterface::class]
                        ));
        Severity: Major
        Found in src/QueryBricks/WhereTrait.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return new ColumnsCriterion($column1, $rule, $column2, $appendRule);
          Severity: Major
          Found in src/QueryBricks/WhereTrait.php - About 30 mins to fix

            Function compileOffsetAndLimitPart has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function compileOffsetAndLimitPart(Query $query, array &$bindings): string
                {
                    $parts = [];
            
                    if ($query->limit !== null) {
            Severity: Minor
            Found in src/Grammars/CommonGrammar.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function compileInCriterion has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function compileInCriterion(InCriterion $criterion, array &$bindings): string
                {
                    if (is_array($criterion->values)) {
                        if (empty($criterion->values)) {
                            return $this->compileEmptyInCriterion($criterion, $bindings);
            Severity: Minor
            Found in src/Grammars/CommonGrammarCriteriaTrait.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function whereIn has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function whereIn($column, $values, bool $not = false, string $appendRule = 'AND'): self
                {
                    $column = $this->checkStringValue('Argument $column', $column);
            
                    if (
            Severity: Minor
            Found in src/QueryBricks/WhereTrait.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language