Sign upLogin

Fiszcz/OLX-flats-notificator

View on GitHub
Star

Showing 4 of 690 total issues

Function getTextOfLocation has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

const getTextOfLocation = (textWithLocation: string) => {
    let wordsCount = 0,
        isSpaceBetweenWords = false,
        lengthOfWord = 0,
        addressStringLength = 0;
Severity: Minor
Found in src/LocationFinder/LocationFinder.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function message has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public get message(): string {
        return (
            '<div align="center">' +
                `<H2>${this.subject}</H2>` +
                '\n' +
Severity: Minor
Found in src/EmailMessage/EmailMessage.ts - About 1 hr to fix

    Function checkTransportTime has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const checkTransportTime = async (flatLocation: string): Promise<TransportInformation[]> => {
    const flatLocationForAPI = flatLocation.split(' ').join('+');
    const requests = transportDestinations.map(destination =>
        axios
            .get<DirectionsResult>(getGoogleMapsAPIUrlRequest(flatLocationForAPI, destination.locationToAPI))
    Severity: Minor
    Found in src/TransportConnection/TransportConnection.ts - About 1 hr to fix

      Function getTextOfLocation has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const getTextOfLocation = (textWithLocation: string) => {
    let wordsCount = 0,
        isSpaceBetweenWords = false,
        lengthOfWord = 0,
        addressStringLength = 0;
      Severity: Minor
      Found in src/LocationFinder/LocationFinder.ts - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language