ForestAdmin/forest-express-mongoose

View on GitHub
src/services/filters-parser.js

Summary

Maintainability
D
2 days
Test Coverage
A
92%

Function FiltersParser has 183 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function FiltersParser(model, timezone, options) {
  const modelSchema = Interface.Schemas.schemas[utils.getModelName(model)];

  const parseInteger = (value) => Number.parseInt(value, 10);
  const parseDate = (value) => new Date(value);
Severity: Major
Found in src/services/filters-parser.js - About 7 hrs to fix

    Function FiltersParser has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
    Open

    function FiltersParser(model, timezone, options) {
      const modelSchema = Interface.Schemas.schemas[utils.getModelName(model)];
    
      const parseInteger = (value) => Number.parseInt(value, 10);
      const parseDate = (value) => new Date(value);
    Severity: Minor
    Found in src/services/filters-parser.js - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function formatConditionForReferences has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      this.formatConditionForReferences = async (condition) => {
        if (_.isEmpty(condition)) {
          throw new InvalidFiltersFormatError('Empty condition in filter');
        }
        if (!_.isObject(condition)) {
    Severity: Major
    Found in src/services/filters-parser.js - About 2 hrs to fix

      Function formatOperatorValue has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        this.formatOperatorValue = async (field, operator, value) => {
          if (this.operatorDateParser.isDateOperator(operator)) {
            return this.operatorDateParser.getDateFilter(operator, value);
          }
      
      
      Severity: Minor
      Found in src/services/filters-parser.js - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status