Sign upLogin

ForestAdmin/forest-express

View on GitHub
Star

Showing 124 of 263 total issues

Avoid too many return statements within this function.
Open

        return response.status(500).send({ error: 'Smart Action: failed to evaluate permissions' });
Severity: Major
Found in src/middlewares/permissions.js - About 30 mins to fix

    Function serializeCards has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function serializeCards(cards, collectionName, meta) {
  function getCustomerAttributes() {
    if (!cards.length) { return []; }

    const schema = Schemas.schemas[collectionName];
    Severity: Minor
    Found in src/integrations/stripe/serializers/cards.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function serializeBankAccounts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function serializeBankAccounts(bankAccounts, collectionName, meta) {
  function getCustomerAttributes() {
    if (!bankAccounts.length) { return []; }

    const schema = Schemas.schemas[collectionName];
    Severity: Minor
    Found in src/integrations/stripe/serializers/bank-accounts.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _getSmartActionName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      _getSmartActionName(request) {
    const smartActionEndpoint = `${request.baseUrl}${request.path}`;
    const smartActionHTTPMethod = request.method;

    const smartAction = Schemas.schemas[this.collectionName].actions.find((action) => {
    Severity: Minor
    Found in src/middlewares/permissions.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language