Sign upLogin

ForestAdmin/forest-express

View on GitHub
Star
src/routes/stats.js

Summary

Maintainability
D
2 days
Test Coverage
F
59%

Function Stats has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function Stats(app, model, Implementation, opts) {
  const { chartHandler, modelsManager } = inject();
  const modelName = Implementation.getModelName(model);
  const permissionMiddlewareCreator = new PermissionMiddlewareCreator(modelName);
Severity: Minor
Found in src/routes/stats.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Stats has 134 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function Stats(app, model, Implementation, opts) {
  const { chartHandler, modelsManager } = inject();
  const modelName = Implementation.getModelName(model);
  const permissionMiddlewareCreator = new PermissionMiddlewareCreator(modelName);
Severity: Major
Found in src/routes/stats.js - About 5 hrs to fix

    Function getWithLiveQuery has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      this.getWithLiveQuery = async (request, response, next) => {
    try {
      const { query, contextVariables } = await chartHandler.getQueryForChart({
        userId: request.user.id,
        renderingId: request.user.renderingId,
    Severity: Major
    Found in src/routes/stats.js - About 2 hrs to fix

      Function get has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        this.get = async (request, response, next) => {
    let promise = null;

    function getAssociationModel(schema, associationName) {
      const field = _.find(schema.fields, { field: associationName });
      Severity: Minor
      Found in src/routes/stats.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                  if (result.length) {
            result.forEach((resultLine) => {
              if (resultLine.value === undefined || resultLine.key === undefined) {
                throw getErrorQueryColumnsName(resultLine, '\'key\', \'value\'');
              }
        Severity: Major
        Found in src/routes/stats.js and 1 other location - About 1 hr to fix
        src/routes/stats.js on lines 127..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                  if (result.length) {
            result.forEach((resultLine) => {
              if (resultLine.value === undefined || resultLine.key === undefined) {
                throw getErrorQueryColumnsName(resultLine, '\'key\', \'value\'');
              }
        Severity: Major
        Found in src/routes/stats.js and 1 other location - About 1 hr to fix
        src/routes/stats.js on lines 118..124

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              const { query, contextVariables } = await chartHandler.getQueryForChart({
        userId: request.user.id,
        renderingId: request.user.renderingId,
        chartRequest: request.body,
      });
        Severity: Minor
        Found in src/routes/stats.js and 1 other location - About 40 mins to fix
        src/routes/stats.js on lines 39..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            const chart = await chartHandler.getChartWithContextInjected({
      userId: request.user.id,
      renderingId: request.user.renderingId,
      chartRequest: request.body,
    });
        Severity: Minor
        Found in src/routes/stats.js and 1 other location - About 40 mins to fix
        src/routes/stats.js on lines 87..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Wontfix

            app.post(path.generate(`stats/${modelName}`, opts), auth.ensureAuthenticated, permissionMiddlewareCreator.stats(), this.get);
        Severity: Major
        Found in src/routes/stats.js and 4 other locations - About 35 mins to fix
        src/routes/resources.js on lines 166..171
        src/routes/resources.js on lines 172..177
        src/routes/resources.js on lines 184..189
        src/routes/resources.js on lines 190..195

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status