Sign upLogin

FredericHeem/starhackit

View on GitHub
Star
server/src/plugins/users/jobs/mail/MailJob.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function MailJob has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function MailJob(config, sendMail) {
  let log = require("logfilename")(__filename);

  log.debug("MailJob options: ", config.mail);
Severity: Major
Found in server/src/plugins/users/jobs/mail/MailJob.js - About 4 hrs to fix

    Function MailJob has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    function MailJob(config, sendMail) {
  let log = require("logfilename")(__filename);

  log.debug("MailJob options: ", config.mail);
    Severity: Minor
    Found in server/src/plugins/users/jobs/mail/MailJob.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sendEmail has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const sendEmail = async (type, user) => {
    log.debug("sendEmail %s to user ", type, user);
    if (!user.email) {
      log.error("email not set");
      throw { name: "email not set" };
    Severity: Minor
    Found in server/src/plugins/users/jobs/mail/MailJob.js - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status