FreeAllMedia/appeal

View on GitHub

Showing 3 of 20 total issues

File request.spec.js has 277 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const sinon = require("sinon");

import Request from "../lib/request.js";
import Router from "omnirouter";
import Response from "../lib/response.js";
Severity: Minor
Found in es6/spec/request.spec.js - About 2 hrs to fix

    Function results has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        results(callback) {
            const _ = privateData(this);
            let options = {
                    method: _.method,
                    url: _.url,
    Severity: Minor
    Found in es6/lib/request.js - About 1 hr to fix

      Function results has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          results(callback) {
              const _ = privateData(this);
              let options = {
                      method: _.method,
                      url: _.url,
      Severity: Minor
      Found in es6/lib/request.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language