Sign upLogin

FreeAllMedia/dovima

View on GitHub
Star
es6/lib/model/fetch.js

Summary

Maintainability
D
1 day
Test Coverage

Function fetchByHasOne has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function fetchByHasOne(associationName, associations, callback) {
  const modelFinder = new ModelFinder(this.database);
  const association = associations[associationName];
  const ModelClass = association.constructor;
Severity: Major
Found in es6/lib/model/fetch.js - About 2 hrs to fix

    Function fetchFromDatabase has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function fetchFromDatabase(fields = [this.primaryKey], callback = undefined) {
  let database = this.database;
  if (!database) { throw new Error("Cannot fetch without Model.database set."); }

  let chain = database
    Severity: Major
    Found in es6/lib/model/fetch.js - About 2 hrs to fix

      Function fetchByHasMany has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function fetchByHasMany(associationName, associations, callback) {
  const association = associations[associationName];

  if (association.through) {
    const throughAssociation = associations[association.through];
      Severity: Minor
      Found in es6/lib/model/fetch.js - About 1 hr to fix

        Function fetchWhere has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function fetchWhere(modelClass, key, conditionType, ids, target, callback) {
        Severity: Minor
        Found in es6/lib/model/fetch.js - About 45 mins to fix

          Function fetchByHasOne has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function fetchByHasOne(associationName, associations, callback) {
  const modelFinder = new ModelFinder(this.database);
  const association = associations[associationName];
  const ModelClass = association.constructor;
          Severity: Minor
          Found in es6/lib/model/fetch.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function fetch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          export default function fetch(...options) {
  switch(options.length) {
    case 0:
      fetchBy.call(this);
      break;
          Severity: Minor
          Found in es6/lib/model/fetch.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      case "belongsTo":
              modelIds = models.map(model => { return model[destinationAssociation.foreignId]; });
              fetchWhere.call(this, association.constructor, tempModel.primaryKey, "in", modelIds, this[associationName], callback);
              break;
          Severity: Major
          Found in es6/lib/model/fetch.js and 2 other locations - About 1 hr to fix
          es6/lib/model/fetch.js on lines 119..122
          es6/lib/model/fetch.js on lines 124..127

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      case "hasOne":
              modelIds = models.map(model => { return model[throughAssociation.foreignId]; });
              fetchWhere.call(this, association.constructor, tempModel.primaryKey, "in", modelIds, this[associationName], callback);
              break;
          Severity: Major
          Found in es6/lib/model/fetch.js and 2 other locations - About 1 hr to fix
          es6/lib/model/fetch.js on lines 124..127
          es6/lib/model/fetch.js on lines 129..132

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                      case "hasMany":
              modelIds = models.map(model => { return model[model.primaryKey]; });
              fetchWhere.call(this, association.constructor, destinationAssociation.foreignId, "in", modelIds, this[associationName], callback);
              break;
          Severity: Major
          Found in es6/lib/model/fetch.js and 2 other locations - About 1 hr to fix
          es6/lib/model/fetch.js on lines 119..122
          es6/lib/model/fetch.js on lines 129..132

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              const processWhereCondition = (value) => {
      if (typeof value === "string") {
        const snakeCasedValue = inflect(value).snake.toString();
        return snakeCasedValue;
      } else {
          Severity: Minor
          Found in es6/lib/model/fetch.js and 1 other location - About 40 mins to fix
          es6/lib/collection.js on lines 62..69

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status