Sign upLogin

FreeAllMedia/forbin

View on GitHub
Star
es6/lib/forbin.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function setupFilterProcessor has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  [setupFilterProcessor](actionName) {
    const originalAction = this[actionName];
    const self = this;

    this[actionName] = (request, response) => {
Severity: Minor
Found in es6/lib/forbin.js - About 1 hr to fix

    Function skip has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      skip(...options) {
    let filterToAvoid,
      actionsToAvoid;

    switch(options.length) {
    Severity: Minor
    Found in es6/lib/forbin.js - About 1 hr to fix

      Function addFilter has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        [addFilter](owner, ...options) {
    let filter = null;
    switch(options.length) {
      case 1:
        filter = options[0];
      Severity: Minor
      Found in es6/lib/forbin.js - About 1 hr to fix

        Function actionName has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            this[actionName] = (request, response) => {
      let originalEnd;
      if(response && response.end) {
         originalEnd = response.end;
      }
        Severity: Minor
        Found in es6/lib/forbin.js - About 1 hr to fix

          Function setupFilterProcessor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            [setupFilterProcessor](actionName) {
    const originalAction = this[actionName];
    const self = this;

    this[actionName] = (request, response) => {
          Severity: Minor
          Found in es6/lib/forbin.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            [processBeforeFilters](action, request, response, callback) {
    this[processFilters](this[getFilters](action, privateData(this)._filters.before), request, response, callback);
  }
          Severity: Minor
          Found in es6/lib/forbin.js and 1 other location - About 35 mins to fix
          es6/lib/forbin.js on lines 227..229

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            [processAfterFilters](action, request, response, callback) {
    this[processFilters](this[getFilters](action, privateData(this)._filters.after), request, response, callback);
  }
          Severity: Minor
          Found in es6/lib/forbin.js and 1 other location - About 35 mins to fix
          es6/lib/forbin.js on lines 223..225

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status