FreeAllMedia/forbin

View on GitHub

Showing 6 of 42 total issues

File forbin.spec.js has 584 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Controller from "../../index";
import flowsync from "flowsync";
import sinon from "sinon";

describe("Controller(...options)", () => {
Severity: Major
Found in es6/spec/forbin.spec.js - About 1 day to fix

    Function setupFilterProcessor has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      [setupFilterProcessor](actionName) {
        const originalAction = this[actionName];
        const self = this;
    
        this[actionName] = (request, response) => {
    Severity: Minor
    Found in es6/lib/forbin.js - About 1 hr to fix

      Function skip has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        skip(...options) {
          let filterToAvoid,
            actionsToAvoid;
      
          switch(options.length) {
      Severity: Minor
      Found in es6/lib/forbin.js - About 1 hr to fix

        Function addFilter has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          [addFilter](owner, ...options) {
            let filter = null;
            switch(options.length) {
              case 1:
                filter = options[0];
        Severity: Minor
        Found in es6/lib/forbin.js - About 1 hr to fix

          Function actionName has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              this[actionName] = (request, response) => {
                let originalEnd;
                if(response && response.end) {
                   originalEnd = response.end;
                }
          Severity: Minor
          Found in es6/lib/forbin.js - About 1 hr to fix

            Function setupFilterProcessor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              [setupFilterProcessor](actionName) {
                const originalAction = this[actionName];
                const self = this;
            
                this[actionName] = (request, response) => {
            Severity: Minor
            Found in es6/lib/forbin.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language