FrenchYeti/dexcalibur

View on GitHub

Showing 446 of 948 total issues

Avoid too many return statements within this function.
Open

    if(paramOnly === false) return false;
Severity: Major
Found in inspectors/BytecodeCleaner/service/main.js - About 30 mins to fix

    Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        constructor(config=null){
    
            this.attr = {};
    
    
    
    Severity: Minor
    Found in src/AndroidAppComponents.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        constructor(config=null){
            this.icon = null;
            this.label = null;
            this.name = null;
    
    
    Severity: Minor
    Found in src/AndroidAppComponents.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function invoke has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        invoke: function(src,raw_src){
            let instr = new CLASS.Instruction(); 
            let m = Core.RX.INVOKE.exec(raw_src), meth=null;        
            let regs = raw_src.substr(0,raw_src.lastIndexOf(","));
            
    Severity: Minor
    Found in src/Opcode.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        constructor(config=null){
            this.enabled=null;
            this.exported=null;
            this.icon=null;
            this.label=null;
    Severity: Minor
    Found in src/AndroidAppComponents.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function appendBlock has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    Method.prototype.appendBlock = function(block, callback=null){
        if(block instanceof BasicBlock){
            block.offset = this.instr.length;
            this.instr.push(block);
            if(callback != null && callback.basicblock != null) 
    Severity: Minor
    Found in src/CoreClass.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function download has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        static async download( pRemoteURL, pLocalPath, pOptions = { force: false } ){
    
            if( (_fs_.existsSync(pLocalPath) == true) && pOptions.force ){
                _fs_.unlinkSync(pLocalPath);
            }
    Severity: Minor
    Found in src/Downloader.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function useSyscalls has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    Analyzer.prototype.useSyscalls = function(syscalls){
        //this.db.syscalls = {};
        for(let i=0; i<syscalls.length ; i++){
            for(let j=0; j<syscalls[i].sysnum.length; j++){
                if(syscalls[i].sysnum[j]>-1){
    Severity: Minor
    Found in src/Analyzer.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function modifier has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        modifier(src){
            if(src instanceof String) src=src.split(LEX.TOKEN.SPACE);
            let mod = new Accessor.AccessFlags() , next=true;
    
            //if(src.length<2) return ERR_PARSE;
    Severity: Minor
    Found in src/SmaliParser.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getMethodSignature has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    DEXC_MODULE.reflect.getMethodSignature = function(method,argTypes){
        var sign="";
    
        var cls = Java.cast( method.getDeclaringClass(), CLS.java.lang.Class);
        var args = DEXC_MODULE.reflect.castArray( CLS.java.lang.Class, argTypes); // method.getParameterTypes());
    Severity: Minor
    Found in src/requires/Reflect.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function java_getMethod has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    Class.prototype.java_getMethod = function(pName, pArgumentsTypes){
        
        for(let i in this.methods){
            if(this.methods[i].name == pName){
                for(let j=0; j<pArgumentsTypes.length; j++){
    Severity: Minor
    Found in src/CoreClass.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function import has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    Method.prototype.import = function(obj){
        // raw impport
        this.raw_import(obj);
        // estor modifiers
        this.modifiers = new Accessor.AccessFlags(obj.modifiers);
    Severity: Minor
    Found in src/CoreClass.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function union has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    FinderResult.prototype.union = function(resultSet){
    
        if(typeof resultSet === 'string' || resultSet instanceof String){
            let res = this._finder._find(resultSet);
            res.data.map((k,v)=>{
    Severity: Minor
    Found in src/Finder.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function readFile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    DEXC_MODULE.common.readFile = function(input_file){
    
        var fin = DEXC_MODULE.common.class.java.io.FileInputStream.$new(input_file);
        var content = [];
        var b=null;
    Severity: Minor
    Found in src/requires/Common.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Analyzer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function Analyzer(encoding, finder, ctx=null){
        SmaliParser.setContext(ctx);
    
        var db = this.db = new AnalyzerDatabase(ctx);
    
    
    Severity: Minor
    Found in src/Analyzer.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function annotation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        annotation(src){
            if(this.state != SML_ANNO) return null;
    
            let sml=[], hdl=null;
    
    
    Severity: Minor
    Found in src/SmaliParser.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function type has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        type: function(db, fqcn){
    
            if(fqcn instanceof CLASS.Class){ 
                if(db.classes.hasEntry(fqcn.fqcn)===true)
                    return db.classes.getEntry(fqcn.fqcn);
    Severity: Minor
    Found in src/Analyzer.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function insertIn has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    Analyzer.prototype.insertIn = function(category, inData){
        if(inData instanceof Array){
            for(let i=0; i<inData.length; i++){
                this.db[category].insert(inData[i]);
            }
    Severity: Minor
    Found in src/Analyzer.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function removeFromQueue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        removeFromQueue(pType, pKey){
            let o={};
    
            if(this.queue[pType] !== undefined){
                this.queueSize[pType] = 0;
    Severity: Minor
    Found in inspectors/Saver/SaveManager.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function is has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    Param.prototype.is = function(arg){
        let i=0;
        if((i=arg.indexOf("="))>-1){
            if(this.name instanceof Array)
                return this.name.indexOf(arg.substr(0,i))>-1;
    Severity: Minor
    Found in src/ArgUtils.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language