FrenchYeti/dexcalibur

View on GitHub

Showing 446 of 948 total issues

Function findBasicBlocks has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Analyzer.prototype.findBasicBlocks = function(instr){
    let bblocks = [], blk={};

    blk = {stack:[], next:[], label:null };
    for(let i in instr){
Severity: Minor
Found in src/Analyzer.js - About 1 hr to fix

    Function getMethod has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Class.prototype.getMethod = function(pattern, pExactMatch=0){
        let res0 = [], res1=[], rx={}, match=null;
        if(pExactMatch != CONST.EXACT_MATCH){
            for(let i in pattern){
                rx[i] = new RegExp(pattern[i]);
    Severity: Minor
    Found in src/CoreClass.js - About 1 hr to fix

      Function searchInternalDependencies has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          static searchInternalDependencies(_context_, activity){
              if(activity==null) return false;
      
              let cls = activity.getImplementedBy();
              if(cls == null){
      Severity: Minor
      Found in inspectors/ApplicationTopography/src/ClassAnalyzer.js - About 1 hr to fix

        Function toJsonObject has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Hook.prototype.toJsonObject = function(){
            let o = new Object();
            o.id = this.id;
            o.parentID = this.parentID;
            o.color = this.color;
        Severity: Minor
        Found in src/HookManager.js - About 1 hr to fix

          Function toJsonObject has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          HookSet.prototype.toJsonObject = function(){
              let o = new Object();
              for(let i in this){
                  switch(i){
                      case "id":
          Severity: Minor
          Found in src/HookManager.js - About 1 hr to fix

            Function getDataTypeOf has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            function getDataTypeOf(pType){
                //Logger.debug("getDataTypeOf: ",pType);
                if(pType instanceof CLASS.ObjectType){
                    if(pType.isArray())
                        return DTYPE.ARRAY;
            Severity: Minor
            Found in src/SmaliVM.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function readTypedValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              readTypedValue() {
                const typedValue = {
                  value: null,
                  type: null,
                  rawType: null
            Severity: Minor
            Found in src/libs/BinaryXmlParser.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getIntentFilter has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                getIntentFilter(type,cmp,uid){
                    let result = null;
            
                    switch(type)
                    {
            Severity: Minor
            Found in src/AndroidAppAnalyzer.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function forEachFileOf has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                forEachFileOf: function(path,callback,isDir=false){
                    let dir=null, elemnt=null, ret = null, smali=[], stat=fs.lstatSync(path);
            
                    if(isDir || stat.isDirectory()){
                        dir=fs.readdirSync(path);
            Severity: Minor
            Found in src/Utils.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function fromXml has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                static fromXml(xmlobj){
                    let act = new AndroidService();
            
                    for(let j in xmlobj){
                        switch(j){
            Severity: Minor
            Found in src/AndroidAppComponents.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function fromXml has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                static fromXml(xmlobj){
                    let act = new AndroidProvider();
            
                    for(let j in xmlobj){
                        switch(j){
            Severity: Minor
            Found in src/AndroidAppComponents.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function constructor has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                constructor(config=null){
                    this.description = null;
                    this.label = null;
                    this.name = null;
            
            
            Severity: Minor
            Found in src/AndroidAppComponents.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function fromXml has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                static fromXml(xmlobj){
                    let act = new AndroidActivity();
            
                    for(let j in xmlobj){
                        switch(j){
            Severity: Minor
            Found in src/AndroidAppComponents.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function fromXml has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                static fromXml(xmlobj){
                    let act = new AndroidReceiver();
            
                    for(let j in xmlobj){
                        switch(j){
            Severity: Minor
            Found in src/AndroidAppComponents.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function init has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                init(){
                    if(!_fs_.existsSync(this.path)){
                        _fs_.mkdirSync(this.path, {recursive: true});
                    }    
                    if(!_fs_.existsSync(_path_.join(this.path, DIR_NAME.SAVE))){
            Severity: Minor
            Found in src/Workspace.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _find has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                _find(index, model, pattern, caseSensitive, lazy=false, includeMissing=false){
                    if(pattern === null || pattern === undefined) return new FinderResult(index,this);
            
                    this.cache.push({ index:index, model:model, case:caseSensitive, lazy:lazy });
            
            
            Severity: Minor
            Found in src/Finder.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function findBasicBlocks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            Analyzer.prototype.findBasicBlocks = function(instr){
                let bblocks = [], blk={};
            
                blk = {stack:[], next:[], label:null };
                for(let i in instr){
            Severity: Minor
            Found in src/Analyzer.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function renameStaticInterface has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            function renameStaticInterface(database, method, pContext){
            
                if(!hasSingleCall(method)) return false;
                if(method.args.length==0) return false;
            
            
            Severity: Minor
            Found in inspectors/BytecodeCleaner/service/main.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function toJsonObject has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            HookSet.prototype.toJsonObject = function(){
                let o = new Object();
                for(let i in this){
                    switch(i){
                        case "id":
            Severity: Minor
            Found in src/HookManager.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function app.receiver.new has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                    "app.receiver.new": function (ctx, event) {
                
                        let cls = ctx.find.get.class(event.data.name)
                        if (cls instanceof CLASS.Class) {
                            event.data.setImplementedBy(cls);
            Severity: Minor
            Found in inspectors/ApplicationTopography/main.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language