Sign upLogin

FrenchYeti/dexcalibur

View on GitHub
Star

Showing 502 of 948 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                v = `${indent}${oper.right.enclosingClass.alias!=null?oper.right.enclosingClass.alias:oper.right.enclosingClass.name}.${oper.right.alias!=null?oper.right.alias:oper.right.name}( `;
Severity: Major
Found in src/SmaliVM.js and 1 other location - About 2 hrs to fix
src/SmaliVM.js on lines 3589..3589

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                v = `${indent}${oper.right.enclosingClass.alias!=null?oper.right.enclosingClass.alias:oper.right.enclosingClass.name}.${oper.right.alias!=null?oper.right.alias:oper.right.name}( `;
Severity: Major
Found in src/SmaliVM.js and 1 other location - About 2 hrs to fix
src/SmaliVM.js on lines 3630..3630

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        this.app.route('/api/inspectors/:inspectorID')
            .get(function (req, res) {
                let insp = InspectorManager.getInstance().getEnabledInspector( $.project, req.params.inspectorID);
Severity: Major
Found in src/WebServer.js and 1 other location - About 2 hrs to fix
src/WebServer.js on lines 266..287

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        args.map( pLocation => {
            let instr = method.getInstr(pLocation.bb,pLocation.instr);
            if(instr != null){
                instr.left.map( vParam => {
                    if(vParam.t !== CONST.LEX.TOKEN.PARAM) paramOnly = false;
Severity: Major
Found in inspectors/BytecodeCleaner/service/main.js and 1 other location - About 2 hrs to fix
inspectors/BytecodeCleaner/service/main.js on lines 644..651

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    removeHooksOf(hookset){
        let npro = [];
        for(let i=0; i<this.hooks.length; i++){
            if(this.hooks[i].parentID != hookset.getID()){
                npro.push(this.hooks[i]);
Severity: Major
Found in src/HookManager.js and 1 other location - About 2 hrs to fix
src/HookManager.js on lines 1729..1737

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    removePrologueOf(hookset){
        let npro = [];
        for(let i=0; i<this.prologues.length; i++){
            if(this.prologues[i].parentID != hookset.getID()){
                npro.push(this.prologues[i]);
Severity: Major
Found in src/HookManager.js and 1 other location - About 2 hrs to fix
src/HookManager.js on lines 1740..1748

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    SGET_SHORT:{ 
        byte:0x66, 
        instr:"sget-short", 
        parse: MainParser.regField,
        type: CONST.INSTR_TYPE.GETTER,
Severity: Major
Found in src/Opcode.js and 3 other locations - About 2 hrs to fix
src/Opcode.js on lines 841..849
src/Opcode.js on lines 850..858
src/Opcode.js on lines 859..867

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    SGET_CHAR:{ 
        byte:0x65, 
        instr:"sget-char", 
        parse: MainParser.regField,
        type: CONST.INSTR_TYPE.GETTER,
Severity: Major
Found in src/Opcode.js and 3 other locations - About 2 hrs to fix
src/Opcode.js on lines 841..849
src/Opcode.js on lines 850..858
src/Opcode.js on lines 868..875

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    SGET_BOOLEAN:{ 
        byte:0x63, 
        instr:"sget-boolean", 
        parse: MainParser.regField,
        type: CONST.INSTR_TYPE.GETTER,
Severity: Major
Found in src/Opcode.js and 3 other locations - About 2 hrs to fix
src/Opcode.js on lines 850..858
src/Opcode.js on lines 859..867
src/Opcode.js on lines 868..875

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    SGET_BYTE:{ 
        byte:0x64, 
        instr:"sget-byte", 
        parse: MainParser.regField,
        type: CONST.INSTR_TYPE.GETTER,
Severity: Major
Found in src/Opcode.js and 3 other locations - About 2 hrs to fix
src/Opcode.js on lines 841..849
src/Opcode.js on lines 859..867
src/Opcode.js on lines 868..875

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Class.prototype.updateField = function(field, override=false){
    let diff = this.fields[field.signature()].compare(field);
    // if not identic => update, else nothiong to do
    if(!diff.isIdentic()){
        if(override)
Severity: Major
Found in src/CoreClass.js and 1 other location - About 2 hrs to fix
src/CoreClass.js on lines 675..682

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Class.prototype.updateMethod = function(meth, override=false){
    let diff = this.methods[meth.signature()].compare(meth);
    // if not identic => update, else nothiong to do
    if(!diff.isIdentic()){
        if(override)
Severity: Major
Found in src/CoreClass.js and 1 other location - About 2 hrs to fix
src/CoreClass.js on lines 651..658

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    ADD_DOUBLE:{ byte:0xab, instr:"add-double", ope: CONST.LEX.TOKEN.ADD, parse: MainParser.Format23x, type: CONST.INSTR_TYPE.MATH, reftype: ReferenceType.NONE, format: Format.Format23x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    DIV_DOUBLE:{ byte:0xae, instr:"div-double", ope: CONST.LEX.TOKEN.DIV, parse: MainParser.Format23x, type: CONST.INSTR_TYPE.MATH, reftype: ReferenceType.NONE, format: Format.Format23x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    REM_INT_LIT8:{ byte:0xdc, instr:"rem-int/lit8",  ope: CONST.LEX.TOKEN.REM, parse: MainParser.format_lit16, type: CONST.INSTR_TYPE.MATH,  reftype:ReferenceType.NONE, format:Format.Format22b, flag:Opcode.CAN_THROW | Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                            this.stack.setLocalSymbol(
                                regV, 
                                DTYPE.IMM_NUMERIC,
                                regX[SYMBOL_OPE[oper.opcode.ope]](regV.getValue(), oper.opcode.byte),
                                `${this.getImmediateValue(regX)}${oper.opcode.ope}${this.getImmediateValue(regV)}`);
Severity: Major
Found in src/SmaliVM.js and 1 other location - About 2 hrs to fix
src/SmaliVM.js on lines 1964..1968

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    SUB_DOUBLE:{ byte:0xac, instr:"sub-double", ope: CONST.LEX.TOKEN.SUB, parse: MainParser.Format23x, type: CONST.INSTR_TYPE.MATH, reftype: ReferenceType.NONE, format: Format.Format23x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    XOR_LONG:{ byte:0xa2, instr:"xor-long", ope: CONST.LEX.TOKEN.XOR, parse: MainParser.Format23x, type: CONST.INSTR_TYPE.MATH, reftype: ReferenceType.NONE, format: Format.Format23x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    DIV_INT_2ADDR:{ byte:0xb3, instr:"div-int/2addr", ope: CONST.LEX.TOKEN.DIV, parse: MainParser.move, type: CONST.INSTR_TYPE.MATH, reftype:ReferenceType.NONE, format:Format.Format12x, flag:Opcode.CAN_THROW | Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 993..993
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 39 locations. Consider refactoring.
Open

    REM_DOUBLE_2ADDR:{ byte:0xcf, instr:"rem-double/2addr", ope: CONST.LEX.TOKEN.REM, parse: MainParser.move, type: CONST.INSTR_TYPE.MATH, reftype:ReferenceType.NONE, format:Format.Format12x, flag:Opcode.CAN_CONTINUE | Opcode.SETS_REGISTER | Opcode.SETS_WIDE_REGISTER },
Severity: Major
Found in src/Opcode.js and 38 other locations - About 2 hrs to fix
src/Opcode.js on lines 906..906
src/Opcode.js on lines 907..907
src/Opcode.js on lines 909..909
src/Opcode.js on lines 932..932
src/Opcode.js on lines 933..933
src/Opcode.js on lines 940..940
src/Opcode.js on lines 941..941
src/Opcode.js on lines 942..942
src/Opcode.js on lines 945..945
src/Opcode.js on lines 946..946
src/Opcode.js on lines 947..947
src/Opcode.js on lines 948..948
src/Opcode.js on lines 949..949
src/Opcode.js on lines 950..950
src/Opcode.js on lines 956..956
src/Opcode.js on lines 957..957
src/Opcode.js on lines 958..958
src/Opcode.js on lines 959..959
src/Opcode.js on lines 960..960
src/Opcode.js on lines 965..965
src/Opcode.js on lines 966..966
src/Opcode.js on lines 973..973
src/Opcode.js on lines 974..974
src/Opcode.js on lines 975..975
src/Opcode.js on lines 978..978
src/Opcode.js on lines 979..979
src/Opcode.js on lines 980..980
src/Opcode.js on lines 981..981
src/Opcode.js on lines 982..982
src/Opcode.js on lines 983..983
src/Opcode.js on lines 989..989
src/Opcode.js on lines 990..990
src/Opcode.js on lines 991..991
src/Opcode.js on lines 992..992
src/Opcode.js on lines 998..998
src/Opcode.js on lines 999..999
src/Opcode.js on lines 1006..1006
src/Opcode.js on lines 1007..1007

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language