Showing 503 of 577 total issues
Function infoblock
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
public function infoblock(array $optionlist, string $class, string $level) {
\core\common\Entity::intoThePotatoes();
$locationMarkers = [];
$retval = "";
$optioninfo = \core\Options::instance();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method printOverview
has 90 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function printOverview()
{
$out = [];
$out[] = "<fieldset class='option_container'>
<legend>
File InputValidation.php
has 316 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/*
* *****************************************************************************
* Contributions to this work were made on behalf of the GÉANT project, a
Function __process_p12
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
def __process_p12(self) -> bool:
debug('process_p12')
pfx_file = get_config_path() + '/cat_installer/user.p12'
if CRYPTO_AVAILABLE:
debug("using crypto")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method adminInvitationMail
has 89 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function adminInvitationMail($targets, $introtext, $newtoken, $idpPrettyName, $federation, $type)
{
if (!in_array($introtext, OutsideComm::INVITE_CONTEXTS)) {
throw new \Exception("Unknown invite mode!");
}
Method listDevices
has 88 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function listDevices()
{
$returnarray = [];
$redirect = $this->getAttributes("device-specific:redirect"); // this might return per-device ones or the general one
// if it was a general one, we are done. Find out if there is one such
File Telepath.php
has 311 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/*
* *****************************************************************************
* Contributions to this work were made on behalf of the GÉANT project, a
Method collectClients
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function collectClients()
{
$clientstest = [];
foreach ($this->allReachabilityResults['clients'] as $clients) {
$hostindex = $clients->hostindex;
Method sanitiseInputs
has 84 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function sanitiseInputs(array $listOfEntries) {
$retval = [];
$bad = [];
$multilangAttrsWithC = [];
foreach ($listOfEntries as $objId => $objValueRaw) {
SanityTests
has 28 functions (exceeds 20 allowed). Consider refactoring. Open
class SanityTests extends CAT
{
/* in this section set current CAT requirements */
/**
RADIUSTests
has 28 functions (exceeds 20 allowed). Consider refactoring. Open
class RADIUSTests extends AbstractTest {
/**
* Was the reachability check executed already?
*
Method networkBlock
has 82 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function networkBlock($blocktype, $toBeConfigured, $prettyName)
{
\core\common\Entity::intoThePotatoes();
$eapType = $this->selectedEap;
switch ($blocktype) {
File CertificationAuthorityEduPki.php
has 303 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/*
* ******************************************************************************
* Copyright 2011-2017 DANTE Ltd. and GÉANT on behalf of the GN3, GN3+, GN4-1
Function deleteObsoleteTempDirs
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public static function deleteObsoleteTempDirs() {
$downloadsDirs = [
'site_installers' => dirname(dirname(dirname(dirname(__FILE__)))) . "/var/installer_cache",
'silverbullet' => dirname(dirname(dirname(dirname(__FILE__)))) . "/var/silverbullet"
];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function mailAddressValidSecure
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public static function mailAddressValidSecure($address)
{
$loggerInstance = new \core\common\Logging();
if (!filter_var($address, FILTER_VALIDATE_EMAIL)) {
$loggerInstance->debug(4, "OutsideComm::mailAddressValidSecure: invalid mail address.");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function adminInvitationMail
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public static function adminInvitationMail($targets, $introtext, $newtoken, $idpPrettyName, $federation, $type)
{
if (!in_array($introtext, OutsideComm::INVITE_CONTEXTS)) {
throw new \Exception("Unknown invite mode!");
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function extractIncomingCertsfromEAP
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
private function extractIncomingCertsfromEAP(&$testresults, $tmpDir) {
/*
* EAP's house rules:
* 1) it is unnecessary to include the root CA itself (adding it has
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function relevantNAPTRhostnameResolution
has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring. Open
public function relevantNAPTRhostnameResolution()
{
// make sure the previous tests have been run before we go on
// preceding tests will cascade automatically if needed
if ($this->NAPTR_SRV_executed == RFC7585Tests::RETVAL_NOTRUNYET) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method marshalObject
has 81 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function marshalObject($domElement, $node, $name, $object, $namespace = NULL, $root = false)
{
if (is_null($object)) {
return;
}
File OutsideComm.php
has 301 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/*
* *****************************************************************************
* Contributions to this work were made on behalf of the GÉANT project, a