Showing 529 of 599 total issues

File cat-user.css.php has 1226 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/*
 * *****************************************************************************
 * Contributions to this work were made on behalf of the GÉANT project, a 
 * project that has received funding from the European Union’s Framework 
Severity: Major
Found in web/skins/modern/resources/css/cat-user.css.php - About 3 days to fix

    File main.py has 1052 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    #!/usr/bin/env python3
    """
     * **************************************************************************
     * Contributions to this work were made on behalf of the GÉANT project,
     * a project that has received funding from the European Union’s Framework
    Severity: Major
    Found in devices/linux/Files/main.py - About 2 days to fix

      Method listDevices has 514 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function listDevices($profile = 0, $orAlways = 0) {
              \core\common\Entity::intoThePotatoes();
              $lang = new \core\common\Language();
      /*      Uncomment lines below if you have button images and want to use them
       * 
      Severity: Major
      Found in devices/Devices-template.php - About 2 days to fix

        File action_realmcheck.php has 914 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /*
         * *****************************************************************************
         * Contributions to this work were made on behalf of the GÉANT project, a 
         * project that has received funding from the European Union’s Framework 
        Severity: Major
        Found in web/diag/action_realmcheck.php - About 2 days to fix

          Function collectClients has a Cognitive Complexity of 109 (exceeds 5 allowed). Consider refactoring.
          Open

              private function collectClients()
              {
                  $clientstest = [];
                  foreach ($this->allReachabilityResults['clients'] as $clients) {
                      if ($clients->result == RADIUSTests::RETVAL_SKIPPED) {
          Severity: Minor
          Found in core/diag/RADIUSTestsUI.php - About 2 days to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File cat.css.php has 864 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          /*
           * *****************************************************************************
           * Contributions to this work were made on behalf of the GÉANT project, a 
           * project that has received funding from the European Union’s Framework 
          Severity: Major
          Found in web/resources/css/cat.css.php - About 2 days to fix

            File cat_js.php has 852 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            /*
             * *****************************************************************************
             * Contributions to this work were made on behalf of the GÉANT project, a 
             * project that has received funding from the European Union’s Framework 
            Severity: Major
            Found in web/skins/modern/user/js/cat_js.php - About 2 days to fix

              File RADIUSTests.php has 813 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              
              /*
               * *****************************************************************************
               * Contributions to this work were made on behalf of the GÉANT project, a 
              Severity: Major
              Found in core/diag/RADIUSTests.php - About 1 day to fix

                File diag.php has 798 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                /*
                 * *****************************************************************************
                 * Contributions to this work were made on behalf of the GÉANT project, a 
                 * project that has received funding from the European Union’s Framework 
                Severity: Major
                Found in web/skins/modern/diag/diag.php - About 1 day to fix

                  File SanityTests.php has 687 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  /*
                   * *****************************************************************************
                   * Contributions to this work were made on behalf of the GÉANT project, a 
                  Severity: Major
                  Found in core/SanityTests.php - About 1 day to fix

                    Function listDevices has a Cognitive Complexity of 75 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function listDevices()
                        {
                            $returnarray = [];
                            $redirect = $this->getAttributes("device-specific:redirect"); // this might return per-device ones or the general one
                            // if it was a general one, we are done. Find out if there is one such
                    Severity: Minor
                    Found in core/AbstractProfile.php - About 1 day to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File overview_org.php has 662 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    /*
                     * *****************************************************************************
                     * Contributions to this work were made on behalf of the GÉANT project, a 
                     * project that has received funding from the European Union’s Framework 
                    Severity: Major
                    Found in web/admin/overview_org.php - About 1 day to fix

                      Function setGlobalDynamicResult has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function setGlobalDynamicResult()
                          {
                              if (isset($this->allReachabilityResults['capath'])) {
                                  foreach ($this->allReachabilityResults['capath'] as $capath) {
                                      $this->globalLevelDynamic = max($this->globalLevelDynamic, $capath->level);
                      Severity: Minor
                      Found in core/diag/RADIUSTestsUI.php - About 1 day to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      File edit_silverbullet.php has 644 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      /*
                       * Contributions to this work were made on behalf of the GÉANT project, a 
                       * project that has received funding from the European Union’s Horizon 2020 
                       * research and innovation programme under Grant Agreement No. 731122 (GN4-2).
                      Severity: Major
                      Found in web/admin/edit_silverbullet.php - About 1 day to fix

                        Method __construct has 278 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function __construct()
                            {
                                parent::__construct();
                                common\Entity::intoThePotatoes();
                        
                        
                        Severity: Major
                        Found in core/CAT.php - About 1 day to fix

                          File AbstractProfile.php has 629 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          <?php
                          
                          /*
                           * *****************************************************************************
                           * Contributions to this work were made on behalf of the GÉANT project, a 
                          Severity: Major
                          Found in core/AbstractProfile.php - About 1 day to fix

                            Method displayDeploymentPropertyWidget has 242 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function displayDeploymentPropertyWidget(&$deploymentObject) {
                                // RADIUS status icons
                                $radiusMessages = [
                                    \core\AbstractDeployment::RADIUS_OK => ['icon' => '../resources/images/icons/Tabler/square-rounded-check-filled-green.svg', 'text' => _("Successfully set profile")],
                                    \core\AbstractDeployment::RADIUS_FAILURE => ['icon' => '../resources/images/icons/Tabler/square-rounded-x-filled-red.svg', 'text' => _("Some problem occurred during profile update")],
                            Severity: Major
                            Found in web/admin/overview_org.php - About 1 day to fix

                              Function openroamingRedinessTest has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function openroamingRedinessTest() {
                                      // do OpenRoaming initial diagnostic checks
                                      // numbers correspond to RFC7585Tests::OVERALL_LEVEL
                                      $results = [];
                                      $resultLevel = $this::OVERALL_OPENROAMING_LEVEL_GOOD; // assume all is well, degrade if we have concrete findings to suggest otherwise
                              Severity: Minor
                              Found in core/AbstractProfile.php - About 1 day to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Method htmlHeadCode has 222 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function htmlHeadCode() {
                                      $cat = new \core\CAT();
                                      \core\common\Entity::intoThePotatoes();
                                      $retval = "<script type='text/javascript' src='https://maps.googleapis.com/maps/api/js?key=" . \config\Master::APPEARANCE['google_maps_api_key'] . "'></script>
                                  <script type='text/javascript'>
                              Severity: Major
                              Found in web/lib/admin/MapGoogle.php - About 1 day to fix

                                File API.php has 533 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                <?php
                                
                                /*
                                 * *****************************************************************************
                                 * Contributions to this work were made on behalf of the GÉANT project, a 
                                Severity: Major
                                Found in web/admin/API.php - About 1 day to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language